feat: secret support — hm.secrets["…"], local .env resolution, hm cloud secret CLI#152
Open
markovejnovic wants to merge 11 commits into
Open
feat: secret support — hm.secrets["…"], local .env resolution, hm cloud secret CLI#152markovejnovic wants to merge 11 commits into
markovejnovic wants to merge 11 commits into
Conversation
Drop all TS DSL artifacts (harmont-ts/, ts_engine, build.rs, TS init templates, example pipeline.ts files, TS e2e fixtures) to align with main's TS DSL deletion before merging.
Introduce the hm-core crate as the home for process-level state (Sys) and project-level state (Workspace), and move credential storage into it. The credential store collapses from a two-level (service, account) map to a single token. The cloud issues one user-scoped bearer -- claim_token / redeem_code take no org, and that one token lists every organization the user belongs to -- so keying it by anything was storing one secret under a key that could not discriminate it. A second API base (localhost, staging) is served by HM_API_TOKEN, which is how the integration tests already inject one, so the stored file only ever held a single entry in practice. This is a breaking change to ~/.config/hm/credentials.toml. The old nested shape no longer parses and there is no migration; existing logins must re-run `hm cloud login`. Behaviour changes beyond the move: - The file must be owned by the invoking user and chmod 0600, else load fails. Previously a malformed or insecure file was silently ignored. - Tokens are held as secrecy::SecretString rather than String, so they no longer leak through Debug. They are exposed only at the two points that need a str: HarmontClient::with_base_url and the Authorization header. - HM_API_TOKEN="" is treated as unset. Honouring it sent an empty bearer (a 401) instead of falling back to the stored credential, which bites when CI exports an unset secret as the empty string. Also consolidates the duplicated Workspace. hm-exec/src/domain/workspace.rs and hm-core/workspace.rs were byte-identical; hm-core now owns the only definition and hm-exec drops its hm-config dependency in favour of hm-core. Supporting work: hm-util gains AbsPath/AbsPathBuf and RelPath/RelPathBuf, typed wrappers that carry the absolute/relative invariant; hm-config drops its now-unused anyhow dependency and replaces two hand-written Default impls with SmartDefault. Includes in-progress secrets-provider scaffolding (hm-exec domain::secrets, local/cloud providers) that is not yet wired to a call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.