Commonize IR generation and validation to Rust#166
Draft
markovejnovic wants to merge 9 commits into
Draft
Conversation
Docstring examples updated from removed hm.pipeline([...]) factory form to current decorator-based API. References to deleted modules removed. Note: docs-site MDX regeneration needed (make docs-generate from simci root).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_pipeline.py,_keys.py,keygen.py,json_emit.pyreplaced bylower.rsandkeygen.rsinhm-dsl-engine. Rust is now the single source of truth for IR generation.PipelineGraph.What stays the same
@hm.pipeline, toolchains,Step.sh(), etc.)DslEnginetrait (still returns JSON strings)PipelineGraphIR schemaWhat changes
hm.pipeline([...])factory form removed (decorator-only now) — was only used for Python-side IR generationSubprocessPythonEnginenow deserializes raw step chain envelope and lowers in Rustdump_registry_json()is now zero-arg (cache key params moved to Rust)PyO3 investigation
Researched three PyO3 approaches (extension module, embedded interpreter, pythonize bridge). Conclusion: PyO3 is viable but unnecessary — moving lowering to Rust without PyO3 solved the dual-maintenance problem with zero new build dependencies. Documented as a future Phase 2 option in the plan.
Test plan
cargo test --workspace— all greenuv run --extra dev python -m pytest— 520 passed, 1 skippedcmd_render,cmd_pipelines,cmd_init) passmake docs-generatefrom simci root (docstrings updated, MDX regen needed)