Skip to content

Fix: 'list approve_instance' pipeline id population.#47

Open
BlueLabelscotch wants to merge 2 commits into
harness:mainfrom
BlueLabelscotch:main
Open

Fix: 'list approve_instance' pipeline id population.#47
BlueLabelscotch wants to merge 2 commits into
harness:mainfrom
BlueLabelscotch:main

Conversation

@BlueLabelscotch

Copy link
Copy Markdown

This PR fixes the pipeline information displayed by the 'list approve_instance' command.
Changes:

  • Populate the pipeline_id field from a different API through a fetch_fn in approve.go .
  • Display the pipeline column correctly in list approve_instance.
  • Add tests to verify the pipeline column is populated as expected.

@CLAassistant

CLAassistant commented Jul 6, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mohitsuman

Copy link
Copy Markdown
Collaborator

@BlueLabelscotch can you share the screenshot/video of how the command output looks.

@mohitsuman mohitsuman requested a review from sawka-harness July 7, 2026 07:00
@BlueLabelscotch

BlueLabelscotch commented Jul 7, 2026

Copy link
Copy Markdown
Author

Screenshot 2026-07-06 at 3 23 06 PM //
This is the correct output after the fix.

@BlueLabelscotch

Copy link
Copy Markdown
Author
image

This is before the fix. Same command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants