test(standards): centralize tool allowlists and add AGENTS.md drift guards#577
Draft
cursor[bot] wants to merge 2 commits into
Draft
test(standards): centralize tool allowlists and add AGENTS.md drift guards#577cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Running a pipeline via harness_execute with input_set_ids plus a full pipeline document in `inputs` (either a YAML string or an object with a top-level `pipeline` key) silently dropped the input set: the materialization guard only admitted empty or flat key/value inputs, so these fell through to the `inputSetIdentifiers` query param, which pipeline execute ignores. The run proceeded without the input set applied. Broaden the guard to also handle full-pipeline inputs, and merge the materialized input set as the base with the caller's document as the override (caller wins per variable / stage), sending the result as the YAML execute body — the same mechanism the working UI path uses. Adds tests for both the YAML-string and object input forms. Note: pipeline_v1 still accepts input_set_ids in the shared schema without forwarding them; left as-is pending confirmation of the v1 execute API's input-set contract. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> AI-Session-Id: b8e26a07-057c-406c-bfde-245eb0c917ae AI-Tool: claude-code AI-Model: unknown
…uards - Add tests/coding-standards/allowed-tools.ts as single source of truth for the 11 consolidated MCP tool handlers - Refactor coding-standards tests to import shared allowlists (DRY) - Add agents-md-consistency.test.ts to prevent reverting to stale 10-tool or Zod v3 architecture in AGENTS.md - Add docs-consistency guard against documenting 10 consolidated tools Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Audited the codebase against
docs/coding-standards.mdarchitecture rules. All 85 standards guardrail tests and 2517 unit tests pass.This PR strengthens enforcement to prevent drift back to outdated architecture (10 tools, Zod v3):
tests/coding-standards/allowed-tools.ts— single source of truth for the 11 consolidated MCP tool handlersagents-md-consistency.test.ts— ensures AGENTS.md documents 11 tools, Zod v4, andpnpm standards:checkStandards audit summary
registerTool)identifierFieldson all resourceserrorResult+toMcpError)console.log()in src/.describe()lastNote: The automation prompt referenced 10 tools and Zod v3 — those are outdated. Canonical references are
docs/coding-standards.mdandAGENTS.md(11 tools, Zod v4).Type of Change
Checklist
pnpm testpasses (2517 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (85 tests)pnpm docs:checkpasses (if registry/tool counts changed)Coding Standards (registry-driven MCP model)
server.registerTool()callsconsole.log()insrc/