test(standards): strengthen coding-standards guardrails#582
Draft
cursor[bot] wants to merge 4 commits into
Draft
test(standards): strengthen coding-standards guardrails#582cursor[bot] wants to merge 4 commits into
cursor[bot] wants to merge 4 commits into
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Strengthen automated enforcement of coding-standards.md: - Secret resource remains read-only metadata (no create/update/delete) - HarnessClient uses RateLimiter and redacts error log bodies by default - Write handlers use formatBodyPreview for confirmation prompts - Docs-consistency tests lock key architecture and safety rules in AGENTS.md Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited the codebase against
docs/coding-standards.mdand strengthened automated enforcement so architecture rules stay enforced in CI.Changes
tests/coding-standards/security.test.tswith guardrails for:RateLimiterusage inHarnessClientHarnessClienterror pathsformatBodyPreviewon write confirmation promptstests/coding-standards/docs-consistency.test.tsto lock key architecture/safety rules indocs/coding-standards.mdAGENTS.mdto the canonical coding standards docVerification
pnpm standards:checkpasses (88 tests)pnpm testpasses (2470 tests)Notes
The user-provided standards snapshot listed 10 tools and Zod v3. The canonical repo standard is 11 consolidated tools (includes
harness_schema) and Zod v4 (import * as z from "zod/v4"). Existingdocs-consistency.test.tsandarchitecture.test.tsalready prevent regression to the outdated counts.