test(standards): strengthen coding standards guardrails to 93 checks#585
Draft
cursor[bot] wants to merge 3 commits into
Draft
test(standards): strengthen coding standards guardrails to 93 checks#585cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
…uards - Add tests/coding-standards/allowed-tools.ts as single source of truth for the 11 consolidated MCP tool handlers - Refactor coding-standards tests to import shared allowlists (DRY) - Add agents-md-consistency.test.ts to prevent reverting to stale 10-tool or Zod v3 architecture in AGENTS.md Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Strengthen automated enforcement of coding-standards.md: - Secret resource remains read-only metadata (no create/update/delete) - HarnessClient uses RateLimiter and redacts error log bodies by default - Write handlers use formatBodyPreview for confirmation prompts - Docs-consistency tests lock key architecture and safety rules - AGENTS.md points contributors to docs/coding-standards.md and standards:check Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Audited the codebase against
docs/coding-standards.mdarchitecture rules. The baseline already passed 80 automated guardrails viapnpm standards:check; this PR strengthens enforcement and prevents documentation drift.Note on the standards snapshot: The pasted standards listed 10 consolidated tools and Zod v3. The canonical architecture is 11 tools (includes
harness_schema) and Zod v4 (import * as z from "zod/v4").docs/coding-standards.mdandAGENTS.mdalready reflect this; new tests lock it in.Changes
tests/coding-standards/allowed-tools.ts— single source of truth for the 11 handler allowlists (DRY across standards tests)tests/coding-standards/agents-md-consistency.test.ts— prevents AGENTS.md reverting to stale 10-tool / Zod v3 docstests/coding-standards/security.test.ts— enforces secret read-only metadata,RateLimiterinHarnessClient, default log redaction, andformatBodyPreviewon write confirmationsdocs-consistency.test.ts— locks stderr logging, singleton client, pure-data toolsets, and write-confirmation safety rules in docsAGENTS.mdpointing contributors todocs/coding-standards.mdCompliance summary (no production code violations found)
.describe()chainingType of Change
Checklist
pnpm testpasses (2483 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (93 tests, up from 80)pnpm docs:checkpasses (no registry/tool count changes)Coding Standards (registry-driven MCP model)
server.registerTool()calls