Skip to content

test: cover schema sync additions from PR #584 and #567#586

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/missing-test-coverage-8303
Draft

test: cover schema sync additions from PR #584 and #567#586
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/missing-test-coverage-8303

Conversation

@cursor

@cursor cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

Adds regression tests for upstream Harness schema definitions introduced by the auto-sync workflow in PR #584 (chore/sync-schemas) and PR #567.

Risky behavior now covered

  • DeployAwsAgentCoreRevision — new CD step type bundled in v0 pipeline/template schemas; agents rely on harness_schema path resolution to discover step fields (connectorRef, waitReady, etc.)
  • IdentitiesConfig / IdentitySpec — OIDC identity map types and the identities field on ShellScriptStepNode; incorrect sync would break pipeline authoring for federated identity steps
  • skipPipelineVariables — new field on UpdateReleaseRepoStepInfo; missing from bundle would silently drop GitOps PR variable behavior from schema discovery
  • DynamicStageNodeV1 — new v1 unified stage for inline/remote child pipelines; path resolution must resolve under stages.unified

Test files added/updated

  • tests/schemas/schema-bundle-contract.test.ts — structural contract assertions on bundled schema modules
  • tests/tools/harness-schema-tool.test.tsharness_schema path-resolution integration tests for DeployAwsAgentCoreRevisionStepNode, IdentitiesConfig, and DynamicStageNodeV1

Why these tests materially reduce regression risk

Auto-sync PRs are data-only and merge frequently with no production code changes. Without contract tests, a bad sync (truncated file, dropped namespace rewrite, or missing step group) would only surface when an agent calls harness_schema at runtime. These tests fail fast in CI on every PR, matching the established pattern for prior sync additions (K8sProgressiveCanaryRollback, DeployGoogleAgentRuntimeRevision).

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (test coverage)

Checklist

  • pnpm test passes (targeted: schema-bundle-contract + harness-schema-tool)
  • pnpm typecheck passes
  • pnpm build passes
  • pnpm standards:check passes
  • pnpm docs:check passes
Open in Web View Automation 

thisrohangupta and others added 2 commits July 8, 2026 00:37
Add contract and harness_schema path-resolution tests for upstream
definitions introduced by auto-sync: DeployAwsAgentCoreRevision,
IdentitiesConfig/IdentitySpec, skipPipelineVariables, and
DynamicStageNodeV1. Guards against silent schema bundle regressions
when harness-schema upstream changes land via sync-schemas workflow.

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ thisrohangupta
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants