test: cover schema sync additions from PR #584 and #567#586
Draft
cursor[bot] wants to merge 2 commits into
Draft
test: cover schema sync additions from PR #584 and #567#586cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Add contract and harness_schema path-resolution tests for upstream definitions introduced by auto-sync: DeployAwsAgentCoreRevision, IdentitiesConfig/IdentitySpec, skipPipelineVariables, and DynamicStageNodeV1. Guards against silent schema bundle regressions when harness-schema upstream changes land via sync-schemas workflow. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for upstream Harness schema definitions introduced by the auto-sync workflow in PR #584 (
chore/sync-schemas) and PR #567.Risky behavior now covered
harness_schemapath resolution to discover step fields (connectorRef,waitReady, etc.)identitiesfield onShellScriptStepNode; incorrect sync would break pipeline authoring for federated identity stepsUpdateReleaseRepoStepInfo; missing from bundle would silently drop GitOps PR variable behavior from schema discoverystages.unifiedTest files added/updated
tests/schemas/schema-bundle-contract.test.ts— structural contract assertions on bundled schema modulestests/tools/harness-schema-tool.test.ts—harness_schemapath-resolution integration tests forDeployAwsAgentCoreRevisionStepNode,IdentitiesConfig, andDynamicStageNodeV1Why these tests materially reduce regression risk
Auto-sync PRs are data-only and merge frequently with no production code changes. Without contract tests, a bad sync (truncated file, dropped namespace rewrite, or missing step group) would only surface when an agent calls
harness_schemaat runtime. These tests fail fast in CI on every PR, matching the established pattern for prior sync additions (K8sProgressiveCanaryRollback, DeployGoogleAgentRuntimeRevision).Type of Change
Checklist
pnpm testpasses (targeted: schema-bundle-contract + harness-schema-tool)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses