Skip to content

test: cover remote input_set git context and YAML shape edge cases#589

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/missing-test-coverage-343e
Draft

test: cover remote input_set git context and YAML shape edge cases#589
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/missing-test-coverage-343e

Conversation

@cursor

@cursor cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

Adds regression tests for recently merged input-set git-context fixes (#579, #575) that had execute-path coverage but no registry or harness_get contract tests.

Risky behavior now covered

  • Silent wrong-branch input set resolutionharness_get(resource_type='input_set') and registry input_set GET must forward branch, repo_name, connector_ref, and store_type; omitting branch causes Harness to resolve from the default branch with no error.
  • Combined execute pathharness_execute with input_set_ids + full pipeline YAML inputs + remote git params must still forward git context on the input-set GET before merging.
  • YAML shape tolerancematerializeInputSetsToRuntimeYaml accepts input-set YAML where the pipeline fragment is at the document root (not wrapped in inputSet).

Test files added/updated

  • tests/registry/registry.test.ts — registry dispatch contract for input_set get git query params
  • tests/tools/tool-handlers.test.tsharness_get and harness_execute end-to-end forwarding
  • tests/utils/materialize-input-sets.test.ts — root-level pipeline YAML parsing

Why these tests materially reduce regression risk

The #579 bug silently applied wrong input values (or none) for remote/Git-stored input sets. Production code was fixed and partially tested via harness_execute, but the parallel harness_get path and registry dispatch layer had no assertions. These tests lock the full contract so a future refactor cannot drop git params from either entry point.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other — test coverage

Checklist

  • pnpm test passes (280 tests in touched files)
  • pnpm typecheck passes
  • pnpm build passes
  • pnpm standards:check passes
  • pnpm docs:check passes
Open in Web View Automation 

thisrohangupta and others added 2 commits July 8, 2026 02:08
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

AI-Session-Id: 873eb9d0-994e-4bcb-bfd7-df508b18a0e3
AI-Tool: claude-code
AI-Model: unknown
Add regression tests for #579 paths where omitting git branch on input
set GET silently resolves from the default branch:

- Registry dispatch forwards branch/repo/connector/storeType on input_set get
- harness_get passes git params through the public tool contract
- harness_execute forwards git context when merging input_set_ids with full
  pipeline YAML inputs (#575 + #579 combined path)
- materializeInputSetsToRuntimeYaml accepts pipeline-at-root YAML shape

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ thisrohangupta
❌ cursoragent
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants