test: cover remote input_set git context and YAML shape edge cases#589
Draft
cursor[bot] wants to merge 2 commits into
Draft
test: cover remote input_set git context and YAML shape edge cases#589cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> AI-Session-Id: 873eb9d0-994e-4bcb-bfd7-df508b18a0e3 AI-Tool: claude-code AI-Model: unknown
Add regression tests for #579 paths where omitting git branch on input set GET silently resolves from the default branch: - Registry dispatch forwards branch/repo/connector/storeType on input_set get - harness_get passes git params through the public tool contract - harness_execute forwards git context when merging input_set_ids with full pipeline YAML inputs (#575 + #579 combined path) - materializeInputSetsToRuntimeYaml accepts pipeline-at-root YAML shape Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for recently merged input-set git-context fixes (#579, #575) that had execute-path coverage but no registry or
harness_getcontract tests.Risky behavior now covered
harness_get(resource_type='input_set')and registryinput_setGET must forwardbranch,repo_name,connector_ref, andstore_type; omitting branch causes Harness to resolve from the default branch with no error.harness_executewithinput_set_ids+ full pipeline YAMLinputs+ remote gitparamsmust still forward git context on the input-set GET before merging.materializeInputSetsToRuntimeYamlaccepts input-set YAML where thepipelinefragment is at the document root (not wrapped ininputSet).Test files added/updated
tests/registry/registry.test.ts— registry dispatch contract forinput_setget git query paramstests/tools/tool-handlers.test.ts—harness_getandharness_executeend-to-end forwardingtests/utils/materialize-input-sets.test.ts— root-level pipeline YAML parsingWhy these tests materially reduce regression risk
The #579 bug silently applied wrong input values (or none) for remote/Git-stored input sets. Production code was fixed and partially tested via
harness_execute, but the parallelharness_getpath and registry dispatch layer had no assertions. These tests lock the full contract so a future refactor cannot drop git params from either entry point.Type of Change
Checklist
pnpm testpasses (280 tests in touched files)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses