Skip to content

test: cover input_set git context and DeployAwsAgentCore schema sync#590

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/missing-test-coverage-445b
Draft

test: cover input_set git context and DeployAwsAgentCore schema sync#590
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/missing-test-coverage-445b

Conversation

@cursor

@cursor cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

Adds regression tests for two recently merged changes where production behavior was at risk but test coverage was incomplete.

Risky behavior now covered

  1. Remote input set git context (fix(execute): forward git context so remote input sets resolve correctly #579) — Without branch/repoName/connectorRef/storeType on input-set GET, Harness silently resolves Git-backed input sets from the default branch (wrong values, no error). Tests lock this at both the registry dispatch layer and the public harness_get tool contract.

  2. Schema auto-sync (chore: auto-sync harness schemas #584) — DeployAwsAgentCoreRevision step definitions added to v0 pipeline/template bundles must remain discoverable via harness_schema and present in bundled schema modules (same contract pattern as DeployGoogleAgentRuntimeRevision).

Test files added/updated

  • Added: tests/registry/input-set-git-context.test.ts — registry dispatch git param mapping for input_set get
  • Updated: tests/tools/tool-handlers.test.ts — harness_get forwards git context for remote input sets
  • Updated: tests/schemas/schema-bundle-contract.test.ts — v0 pipeline/template bundle includes DeployAwsAgentCoreRevision
  • Updated: tests/tools/harness-schema-tool.test.ts — harness_schema resolves DeployAwsAgentCoreRevisionStepNode

Why these tests materially reduce regression risk

  • The input-set bug was silent (runs succeeded with wrong inputs) — these tests assert the exact query params that prevent default-branch fallback.
  • Schema sync PRs are automated and large; contract tests catch missing step definitions before agents construct invalid pipeline YAML.

Type of Change

  • Other — test coverage

Checklist

  • pnpm test passes (targeted: 184 tests in touched files)
Open in Web View Automation 

Add regression tests for two recent merge gaps:

- input_set GET must forward branch/repo/connector/storeType git context
  (#579) at both registry dispatch and harness_get tool layers — without
  these params the Harness API silently resolves remote sets from the
  default branch.

- Auto-synced v0 pipeline/template schemas (#584) must expose
  DeployAwsAgentCoreRevision step definitions discoverable via
  harness_schema, following the existing Google agent runtime contract
  test pattern.

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants