Strengthen coding standards guardrails and verify PR #593 compliance#596
Draft
cursor[bot] wants to merge 3 commits into
Draft
Strengthen coding standards guardrails and verify PR #593 compliance#596cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Expose write operations in the idp toolset so agents can manage catalog entities via YAML and scorecards/checks via JSON bodies round-tripped from harness_get. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
- Move scorecardStatsExtract to shared extractors.ts (standards §3) - Add deepLinkTemplate to scorecard_check resource - Add tests/coding-standards/constants.ts as single source for allowed MCP tools - Add AGENTS.md and security consistency tests (87 standards tests total) - Centralize ALLOWED_MCP_TOOLS in architecture and docs-consistency tests Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automated compliance review against
docs/coding-standards.md(triggered by PR #593). The codebase already passes all architecture guardrails; this PR strengthens ongoing enforcement and applies minor standards fixes to the IDP toolset changes.Review findings for PR #593 (IDP create/update)
operationPolicy,bodySchema,bodyBuilder, andidentifierFieldsare correctly declaredconsole.log, or rawfetch()in toolsetsscorecardStatsExtractto sharedsrc/registry/extractors.ts(standards §3)deepLinkTemplatetoscorecard_checkStandards enforcement improvements
tests/coding-standards/constants.ts— single source of truth for the 11 allowed MCP toolstests/coding-standards/agents-consistency.test.ts— prevents AGENTS.md drift (11 tools, Zod v4)tests/coding-standards/security.test.ts— secret metadata contract + noapi_key_secretecho in workflow execute bodyNote on pasted standards snapshot
The automation prompt referenced 10 tools and Zod v3; the canonical repo standard is 11 tools (includes
harness_schema) and Zod v4.docs-consistency.test.tsand the newagents-consistency.test.tsguard against reverting to the outdated snapshot.Type of Change
Checklist
pnpm testpasses (2504 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (87 architecture guardrails)pnpm docs:checkpassesCoding Standards (registry-driven MCP model)
server.registerTool()callssrc/registry/extractors.tsidentifierFieldsandscopedeclared on resourcesconsole.log()insrc/