test: cover AWS Agent Core schema sync (PR #597)#599
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Add bundle contract and harness_schema path resolution tests for DeployAwsAgentCoreRevision, ShiftAwsAgentCoreTraffic, and RollbackAwsAgentCoreRevision CD steps introduced in the upstream schema sync (PR #597). These steps power AWS Bedrock AgentCore deploy/traffic-shift/rollback workflows; missing definitions break harness_schema lookups and pipeline authoring for agent deployments. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for AWS Bedrock AgentCore CD steps synced in PR #597 (
chore: auto-sync harness schemas).Risky behavior now covered
connectorRefandwaitReadyfields; already on main but previously untestedweightandtarget.revisionId; new in chore: auto-sync harness schemas #597connectorRef; new in chore: auto-sync harness schemas #597Missing definitions break
harness_schemapath lookups and pipeline authoring for AWS agent deployment workflows.Test files added/updated
tests/schemas/schema-bundle-contract.test.ts— bundle contract for all three steps in v0 pipeline and template (including_templatevariants)tests/tools/harness-schema-tool.test.ts—harness_schemapath resolution forDeployAwsAgentCoreRevisionStepNodeandShiftAwsAgentCoreTrafficStepNodeWhy these tests materially reduce regression risk
Auto-sync schema PRs can silently drop or misplace CD step definitions in the 100k+ line bundled schema files. These contract tests pin the step node/info presence, type enum values, and critical payload fields — the same pattern used for
DeployGoogleAgentRuntimeRevisionandK8sProgressiveCanaryRollback. Theharness_schematool tests ensure agents can still resolve step definitions by bare name after upstream reordering.Note: Branch fast-forwards
chore/sync-schemasso CI passes before #597 merges. After #597 lands on main, rebase will collapse to a test-only diff.Type of Change
Checklist
pnpm testpasses (targeted:tests/schemas/schema-bundle-contract.test.ts,tests/tools/harness-schema-tool.test.ts)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpassesTriggered by automation inspecting PR #597.