test: strengthen coding-standards guardrails and sync 3.2.10 manifests#605
Draft
cursor[bot] wants to merge 3 commits into
Draft
test: strengthen coding-standards guardrails and sync 3.2.10 manifests#605cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
AI-Session-Id: 103ece16-0d3e-4af0-a493-04e44aa113c9 AI-Tool: claude-code AI-Model: unknown
- Add shared constants.ts for the 11 consolidated MCP tool names - Add AGENTS.md consistency checks (tools, Zod v4, standards:check) - Add security checks (secret metadata, no value leakage, rate limiter) - Move scorecardStatsExtract to shared extractors.ts per standards §3 - Refactor architecture/docs tests to use shared constants Standards suite: 80 -> 88 tests; all pass with pnpm test (2486). Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Complete the version bump by aligning manifest.json and mcp-directory/manifest.json with package.json, and update the release-metadata regression test expectation. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reviewed the codebase against
docs/coding-standards.mdarchitecture rules and strengthened automated enforcement.Standards compliance: The codebase already followed the registry-driven MCP model (11 consolidated tools, pure-data toolsets, singleton
HarnessClient, stderr-only logging).pnpm standards:checkpassed 80 tests on the baseline.This PR strengthens guardrails (80 → 88 tests):
tests/coding-standards/constants.ts— single source of truth for the 11 allowed MCP tool namestests/coding-standards/agents-consistency.test.ts— prevents drift betweenAGENTS.mdand canonical standardstests/coding-standards/security.test.ts— secret metadata descriptions, no secret value field mapping in toolsets, IDP workflow body redaction, rate limiter presencescorecardStatsExtractfrom inlineidp.tsto sharedsrc/registry/extractors.ts(standards §3)Also fixes incomplete 3.2.10 version bump:
manifest.jsonandmcp-directory/manifest.jsonto3.2.10tests/release-metadata.test.tsexpectationType of Change
Checklist
pnpm testpasses (2505 tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (88 tests)pnpm docs:checkpasses (if registry/tool counts changed)Coding Standards (registry-driven MCP model)
If this PR adds or changes Harness API coverage:
server.registerTool()calls — only toolset definitions insrc/registry/toolsets/ALL_TOOLSETSandToolsetNameunionoperationPolicyon every new/changed endpointsrc/registry/extractors.ts(no raw passthrough on real endpoints)identifierFieldsandscopedeclared on new resourcesconsole.log()insrc/(stdio JSON-RPC safety)