test: cover Code file scope forwarding and schema sync contracts#606
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover Code file scope forwarding and schema sync contracts#606cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Add repositories-file-scope tests for file_content get/blame (#602) - Lock in DeployAwsAgentCoreRevision, IdentitiesConfig bundle contracts (#584) - Lock in DynamicStageNodeV1 v1 stage contracts (#567) - Add harness_schema path resolution for new synced definitions Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for recently merged production changes that lacked dedicated test coverage.
Risky behavior now covered
file_contentget and blame must forwardorgIdentifier/projectIdentifierquery params so Harness Code can resolve project-scoped repositories. Without this, agents reading files from project repos get 404s.DeployAwsAgentCoreRevisionstep definitions andIdentitiesConfig/IdentitySpecOIDC identity schemas added to v0 pipeline/template bundles.DynamicStageNodeV1dynamic stage definitions added to v1 pipeline/template bundles.harness_schemapath resolution — Ensures agents can discover the new step/stage/identity schemas by bare name.Test files added/updated
tests/registry/repositories-file-scope.test.ts— 4 tests for file_content get/blame scope query param forwardingtests/schemas/schema-bundle-contract.test.ts— 4 new contract tests for synced schema definitionstests/tools/harness-schema-tool.test.ts— 3 new path resolution testsWhy these tests materially reduce regression risk
queryParamsonfile_contentwould silently break project-scoped Code file reads.harness_schemaresolution tests ensure the discovery path agents rely on stays wired after schema bundle changes.Type of Change
Checklist
pnpm testpasses (44 targeted tests)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses (not applicable — no registry changes)