test: cover Code file scope forwarding and schema sync contracts#610
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover Code file scope forwarding and schema sync contracts#610cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for recently merged production changes: - file_content get/blame must forward orgIdentifier/projectIdentifier (#602) - v0 DeployAwsAgentCoreRevision and IdentitiesConfig schema bundle (#584) - v1 DynamicStageNodeV1 unified stage definitions (#567) - harness_schema nested path resolution for the new definitions Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for recently merged production changes that lacked dedicated coverage:
Risky behavior now covered
Code file scope forwarding (Forward Code scope for file content APIs #602) —
file_contentget and blame must forwardorgIdentifier/projectIdentifierquery params. Without them, Harness Code silently resolves repos at account scope, returning wrong or empty content for org/project-scoped repositories.Schema sync bundle contracts (chore: auto-sync harness schemas #584, chore: auto-sync harness schemas #567) — Auto-synced upstream definitions must remain bundled and discoverable:
DeployAwsAgentCoreRevisionstep node/infoIdentitiesConfig/IdentitySpec(OIDC identity map with maxProperties guard)DynamicStageNodeV1unified stage (dynamic child-pipeline execution)harness_schemanested path resolution — Agents rely on bare-name lookup (DeployAwsAgentCoreRevisionStepNode,IdentitiesConfig,DynamicStageNodeV1). Missing definitions break pipeline authoring workflows silently.Test files added/updated
tests/registry/repositories-file-scope.test.tstests/schemas/schema-bundle-contract.test.tstests/tools/harness-schema-tool.test.tsWhy these tests materially reduce regression risk
queryParamsmapping would re-break scoped file reads with no CI signal.harness_schemadiscovery.Type of Change
Checklist
pnpm testpasses (targeted: 43 tests in 3 files)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses