test: cover Code file scope forwarding and recent schema sync contracts#612
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover Code file scope forwarding and recent schema sync contracts#612cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for production-only fixes merged since the last coverage run: - file_content get/blame orgIdentifier/projectIdentifier forwarding (#602) - DeployAwsAgentCoreRevision, IdentitiesConfig/IdentitySpec (#584) - DynamicStageNodeV1 in v1 pipeline/template (#567) - harness_schema path resolution for the new bundled definitions Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for recently merged production changes that shipped without dedicated test coverage.
Risky behavior now covered
file_contentget and blame must forwardorgIdentifier/projectIdentifierquery params so project-scoped Harness Code repos resolve correctly in QA/prod.DeployAwsAgentCoreRevisionstep definitions andIdentitiesConfig/IdentitySpeccommon types after auto-sync.DynamicStageNodeV1for dynamic child-pipeline stages.harness_schemapath resolution — agents querying bare definition names (DeployAwsAgentCoreRevisionStepNode,IdentitiesConfig,DynamicStageNodeV1) must resolve nested bundled schemas.Test files added/updated
tests/registry/repositories-file-scope.test.tstests/schemas/schema-bundle-contract.test.tstests/tools/harness-schema-tool.test.tsWhy these tests materially reduce regression risk
queryParamsmapping would silently break scoped file reads/blame again.harness_schemanested lookup tests catch path-resolution regressions that would block pipeline authoring workflows.Type of Change
Checklist
pnpm exec vitest runpasses (45 tests across 3 files)pnpm testpassespnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses (not applicable — no registry/tool count changes)