Fix scoped IDP updates and remote pipeline input overrides#613
Draft
cursor[bot] wants to merge 2 commits into
Draft
Fix scoped IDP updates and remote pipeline input overrides#613cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two critical correctness bugs found during recent-commit investigation:
idp_entityget/update path construction now honors explicitresource_scopeand otherwise defaults to configuredHARNESS_ORG/HARNESS_PROJECTwhen available. This prevents a commonharness_list->harness_update(resource_id, params.kind)flow from accidentally PUTing/v1/entities/account/...and overwriting an account-scoped entity with the same kind/id instead of the project entity the agent just listed.pipeline_branch ?? branchwhen fetching the runtime input template, matching the input-set GET and final execute request. This prevents remote pipeline runs that combineinput_set_ids, flat inline overrides, andpipeline_branchfrom resolving overrides against the default-branch template while executing a feature branch.Added regressions for the public IDP update path, explicit account-scope suppression, and full remote pipeline helper branch parity.
Type of Change
Checklist
pnpm testpassespnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (architecture guardrails — see docs/coding-standards.md)pnpm docs:checkpasses (if registry/tool counts changed)Coding Standards (registry-driven MCP model)
If this PR adds or changes Harness API coverage:
server.registerTool()calls — only toolset definitions insrc/registry/toolsets/ALL_TOOLSETSandToolsetNameunionoperationPolicyon every new/changed endpointsrc/registry/extractors.ts(no raw passthrough on real endpoints)identifierFieldsandscopedeclared on new resourcesconsole.log()insrc/(stdio JSON-RPC safety)Not applicable: no new toolset/resource registration was added.