-
Notifications
You must be signed in to change notification settings - Fork 1
Create basic CI/CD for interface package #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @PathogenDavid, were the changes to the files under |
|
@MicBoucinha Correct, it was an indirect consequence of adding the The setting is a bit hidden, but you ask GitHub to collapse whitespace-only changes: Git's default behavior when Unlike everything else in this repo, these few files got stored with CRLF line endings when they were originally added. (You might have multiple computers with differing settings, which is very easy to do by accident because the Git for Windows installer prompts you to choose one. Using WSL and changing your Having CRLF files stored in the repo when |
|
Thanks for the detailed explanation. I will check my devices to confirm which one might have a different configuration for that property. Cheers! |
|
No problem! You might find it helpful to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PathogenDavid finally getting around to merging this PR, but realising it needs a rebase as some of the files have since been renamed (even though content is identical).
If you don't get around to it first I will probably just rebase onto a new branch and then open a new PR from there, so no worries!
|
Yeah definitely best not to wait for me. I'm pretty bandwidth-constrained these days and haven't kept up with my GitHub notifications or OSS stuff basically at all lately 🫠 Hope things are going well! |

(This PR was created semi-automatically.)
This PR brings extremely bare-bones CI/CD for the interface package to aid with the Bonsai 2.9 release. It is not indicative of long-term plans for improved Harp CI/CD.
Note: Some Harp devices had their
PackageTypeadded by Bruno and have already been published on NuGet.org.