Skip to content

Remove redundant _SEL suffix #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glopesdev merged 1 commit into from
Mar 22, 2026
Merged

Remove redundant _SEL suffix #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/AppRegs.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,10 @@ foreach (var groupMask in DeviceMetadata.GroupMasks)
var mask = groupMask.Value;
var maskSelect = TemplateHelper.GetMaskSelect(mask).ToString("X2");
var maskName = TemplateHelper.GetFirmwareGroupMaskName(groupMask.Key);
var maskNamePadding = new string(' ', maxMaskNameLength - maskName.Length);
var maskNamePadding = new string(' ', maxMaskNameLength - maskName.Length + 4);
var maskSelectPadding = new string(' ', 11 - maskSelect.Length);
#>
#define MSK_<#= maskName #>_SEL<#= maskNamePadding #>0x<#= maskSelect #><#= maskSelectPadding #>//
#define MSK_<#= maskName #><#= maskNamePadding #>0x<#= maskSelect #><#= maskSelectPadding #>//
<#

foreach (var member in mask.Values)
Expand Down
4 changes: 2 additions & 2 deletions tests/ExpectedOutput/device.app_ios_and_regs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,12 +190,12 @@ typedef struct
#define B_TEST_DI_PORT1 (1<<9) //
#define B_SUPPLY_PORT0 (1<<10) //
#define B_PORT_DIO1 (1<<11) //
#define MSK_PWM_PORT_SEL 0x0F //
#define MSK_PWM_PORT 0x0F //
#define GM_PWM_PORT_PWM0 0x01 //
#define GM_PWM_PORT_PWM1 0x02 //
#define GM_PWM_PORT_PWM2 0x04 //
#define GM_PWM_PORT_PWM3 0x0A //
#define MSK_ENCODER_MODE_SEL 0x01 //
#define MSK_ENCODER_MODE 0x01 //
#define GM_ENCODER_MODE_POSITION 0x00 //
#define GM_ENCODER_MODE_DISPLACEMENT 0x01 //

Expand Down
Loading