Skip to content

Refactored the code to enable the use of plugins. Considering new features (This is still a WIP, See below for more info)#84

Open
DeadIndian wants to merge 4 commits into
harshendram:mainfrom
AdvancedDiscordBot:main
Open

Refactored the code to enable the use of plugins. Considering new features (This is still a WIP, See below for more info)#84
DeadIndian wants to merge 4 commits into
harshendram:mainfrom
AdvancedDiscordBot:main

Conversation

@DeadIndian
Copy link
Copy Markdown
Contributor

So basically I added plugin functionality, but halfway through adding this I got an idea, why don't we make this into a proper ecosystem....? Like allow people to publish their plugins as npm packages and give server owners a GUI to help them easily add plugins (Ofc bigger plugins will need a restart of the bot to take effect) but this can significantly improve the UX.

But this is a major step and implementing this will bring in a lot of additional complexity, Before I went all in I just wanted to confirm that you are OK with this, because recently I realised that contributing code is just the beginning, maintaining it is the real issue(I will still be around to help improve and maintain this project, but still you the Owner so its you call), and I cant just put a massive feature dump and expect you to take it all in, so just wanted to make sure you were ok with this.

DO NOT APPROVE THIS PR JUST YET, tell me if this direction is ok with you, I will keep working on this and will add to this and finish it later.

@DeadIndian
Copy link
Copy Markdown
Contributor Author

I know that you might be busy with you own stuff, so really sorry for putting this burden on you 😅

I also have a few things to discuss reg. how we will implement the plugin ecosystem (mainly reg. dependency management with plugins, version management, and moderating on what goes into the marketplace) , but just wanted to make sure that you were on board with this idea before we proceed.

@DeadIndian
Copy link
Copy Markdown
Contributor Author

@harshendram We might have to make a Org for this bot...

@harshendram
Copy link
Copy Markdown
Owner

I am really sorry to see this late ...

hey nice to see you here again, first of all i would like to clarify that I am hardly maintaining this project since i am busy with my own things to do and is not at all part of this year gssoc also when i first started this project i needed it to be simple and easy to use so that ppl who are not so well with coding (usually mods) can use it without any friction and i did think about plugin system gui etc everything back then i also thought that newer ppl who are contributing it will be easy and a "meaningful" contribution to them for adding commands etc getting comfortable with discord.js

so I am also in a "confused" state about the future of this project, and as you said about investing your time in this project to develop it fully will be your call since most of the features of this discord bot can be easily done by claude one shot for their particular needs of mods/users, if your pure intention is to contribute to this project/opensource then you can go for it i will be lightly managing the PR or may setup coderabbit or something as i am really busy atp of my life...

so long story short, please consider your time and complexity of this project and if you are showcasing this project somewhere/resume/discussions in interviews then this project should have a novel feature which will set us apart from other repos which are also similar to mine.

as always stay happy :)

@DeadIndian
Copy link
Copy Markdown
Contributor Author

I am really sorry to see this late ...

hey nice to see you here again, first of all i would like to clarify that I am hardly maintaining this project since i am busy with my own things to do and is not at all part of this year gssoc also when i first started this project i needed it to be simple and easy to use so that ppl who are not so well with coding (usually mods) can use it without any friction and i did think about plugin system gui etc everything back then i also thought that newer ppl who are contributing it will be easy and a "meaningful" contribution to them for adding commands etc getting comfortable with discord.js

so I am also in a "confused" state about the future of this project, and as you said about investing your time in this project to develop it fully will be your call since most of the features of this discord bot can be easily done by claude one shot for their particular needs of mods/users, if your pure intention is to contribute to this project/opensource then you can go for it i will be lightly managing the PR or may setup coderabbit or something as i am really busy atp of my life...

so long story short, please consider your time and complexity of this project and if you are showcasing this project somewhere/resume/discussions in interviews then this project should have a novel feature which will set us apart from other repos which are also similar to mine.

as always stay happy :)

Yep... Actually the whole reason I am doing this is because there is no bot out there with this open source+plugin thing, I knew that this project exists, so i started on top of this without making it from scratch.

I have already made a org for adb, so I am happy to just fork it and continue maintaining it. If you want to contribute in the future you can just maintain the repo in the org. This could be a classic case of fork of a repo to keep it going :)

(And yes, it can be generated with claude in one shot, but I just wanted to have this be a fork of another repo, because before claude if i had to do it i would definitely have forked it to not re invent the wheel. Also generating a new one will cost tokens plus additional debugging and stuff like that, and the current structure is pretty modular anyways, so i decided to go with this.)

Thank you for being honest and upfront, I am happy to maintain this project in my fork. If you ever feel like contributing again in the future, please DM me on discord (@DeadIndian).

See ya later ig.. Good luck with your life!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants