Skip to content

Added Missing HTML Ids which are referred in js to HTML file #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamrajatg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added Missing HTML Ids which are referred in js to HTML file #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca94daf
Added missing HTML IDs to html file due to which reset function was t…
iamrajatg Oct 3, 2020
1776424
Added Comment to h1 dom selection
iamrajatg Oct 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion colorGame.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
body {
background-color: #232323;
margin: 0;
font-family: 'Open Sans', sans-serif;
font-family: "Open Sans", sans-serif;
color: #fff;
}

.square {
width: 30%;
background: purple;
Expand Down
113 changes: 52 additions & 61 deletions colorGame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,110 +1,101 @@
var numSquares = 6;
var colors = [];
var pickedColor;
var squares = document.querySelectorAll('.square');
var colorDisplay = document.getElementById('colorDisplay');
var messageDisplay = document.querySelector('#message');
var h1 = document.querySelector('h1');
var resetButton = document.querySelector('#reset');
var modeButtons = document.querySelectorAll('.mode');

init();
var numSquares = 6
var colors = []
var pickedColor
var squares = document.querySelectorAll(".square")
var colorDisplay = document.getElementById("colorDisplay")
var messageDisplay = document.querySelector("#message")
//var h1 = document.querySelector("h1")
var resetButton = document.querySelector("#reset")
var modeButtons = document.querySelectorAll(".mode")

init()

function init() {

setUpModeButtons();
setUpSquares();
reset();
setUpModeButtons()
setUpSquares()
reset()
}

function setUpModeButtons() {
for (var i = 0; i < modeButtons.length; i++) {
modeButtons[i].addEventListener('click', function() {
modeButtons[0].classList.remove('selected');
modeButtons[1].classList.remove('selected');
this.classList.add('selected');
numSquares = this.textContent === "Easy" ? 3 : 6;
reset();
});
modeButtons[i].addEventListener("click", function () {
modeButtons[0].classList.remove("selected")
modeButtons[1].classList.remove("selected")
this.classList.add("selected")
numSquares = this.textContent === "Easy" ? 3 : 6
reset()
})
}
}

function setUpSquares() {
for (var i = 0; i < squares.length; i++) {

squares[i].addEventListener("click", function() {

var clickedColor = this.style.background;
squares[i].addEventListener("click", function () {
var clickedColor = this.style.background

if (clickedColor === pickedColor) {
messageDisplay.textContent = 'Correct!';
resetButton.textContent = "Play Again?";
changeColors(clickedColor);
h1.style.background = clickedColor;
messageDisplay.textContent = "Correct!"
resetButton.textContent = "Play Again?"
changeColors(clickedColor)
h1.style.background = clickedColor
} else {
this.style.background = "#232323";
messageDisplay.textContent = 'Try Again!';
this.style.background = "#232323"
messageDisplay.textContent = "Try Again!"
}
});
})
}
}

function reset() {
colors = generateRandomColors(numSquares)

colors = generateRandomColors(numSquares);
pickedColor = pickColor()

pickedColor = pickColor();

colorDisplay.textContent = pickedColor;
resetButton.textContent = "New Colors";
messageDisplay.textContent = "";
colorDisplay.textContent = pickedColor
resetButton.textContent = "New Colors"
messageDisplay.textContent = ""

for (var i = 0; i < squares.length; i++) {
if (colors[i]) {
squares[i].style.display = "block";
squares[i].style.background = colors[i];
squares[i].style.display = "block"
squares[i].style.background = colors[i]
} else {
squares[i].style.display = "none";
squares[i].style.display = "none"
}
}
h1.style.background = 'steelblue';
// h1.style.background = 'steelblue';
}

resetButton.addEventListener('click', function() {
reset();
});
resetButton.addEventListener("click", function () {
reset()
})

function changeColors(color) {

for (var i = 0; i < colors.length; i++) {

squares[i].style.background = color;
squares[i].style.background = color
}
}

function pickColor() {
var random = Math.floor(Math.random() * colors.length);
return colors[random];
var random = Math.floor(Math.random() * colors.length)
return colors[random]
}

function generateRandomColors(num) {

var arr = [];
var arr = []

for (var i = 0; i < num; i++) {

arr.push(randomColor());
arr.push(randomColor())
}

return arr;
return arr
}

function randomColor() {
var r = Math.floor(Math.random() * 256)

var r = Math.floor(Math.random() * 256);

var g = Math.floor(Math.random() * 256);
var g = Math.floor(Math.random() * 256)

var b = Math.floor(Math.random() * 256);
return "rgb(" + r + ", " + g + ", " + b + ")";
var b = Math.floor(Math.random() * 256)
return "rgb(" + r + ", " + g + ", " + b + ")"
}
35 changes: 20 additions & 15 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,31 @@
<html>
<head>
<link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.5.2/css/bootstrap.min.css" integrity="sha384-JcKb8q3iqJ61gNV9KGb8thSsNjpSL0n8PARn9HuZOnIxN0hoP+VmmDGMN5t9UJ0Z" crossorigin="anonymous">
<title> COLOR GAME </title>
<link rel="stylesheet" type="text/css" href="colorGame.css">
<link
rel="stylesheet"
href="https://stackpath.bootstrapcdn.com/bootstrap/4.5.2/css/bootstrap.min.css"
integrity="sha384-JcKb8q3iqJ61gNV9KGb8thSsNjpSL0n8PARn9HuZOnIxN0hoP+VmmDGMN5t9UJ0Z"
crossorigin="anonymous"
/>
<title>COLOR GAME</title>
<link rel="stylesheet" type="text/css" href="colorGame.css" />
</head>
<body>
<div class="display-4" align="center" >The Great</div>
<div class="display-2" align="center"> Color here</div>
<div class="display-4" align="center" >Game</div>
<div id="stripe" align="center">
<button id="btn">New Colors</button>
<span id="status"> Wrong Answer </span>
<div class="display-4" align="center">The Great</div>
<div class="display-2" id="colorDisplay" align="center">Color here</div>
<div class="display-4" align="center">Game</div>
<div id="stripe" align="center">
<button id="reset">New Colors</button>
<span id="message"> Wrong Answer </span>
<button id="ebtn">Easy</button>
<button id="hbtn">Hard</button>
</div>
<div id="container">
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
<div class="square"></div>
</div>
<script type="text/javascript" src="colorGame.js"></script>
</body>
Expand Down