fix(date): %s returns Unix epoch unaffected by display timezone#932
Merged
Conversation
The %s handler read LiquidDate.getTime(), which returns the displayDate deliberately shifted by the display timezone offset for wall-clock getters. With a timezone argument or timezoneOffset option set, %s produced an epoch shifted by (server offset - display offset) instead of the true Unix timestamp. Expose the unshifted time as LiquidDate.dateValue() and use it for %s. Also switch Math.round to Math.floor so fractional seconds truncate toward the epoch like Ruby strftime. Fixes harttle#931
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #931
%sreadLiquidDate.getTime(), which returns thedisplayDatedeliberately shifted by the display timezone offset (so wall-clock getters can delegate toDate). With a timezone filter argument or thetimezoneOffsetoption set,%sproduced an epoch shifted by(server offset − display offset)instead of the true Unix timestamp — the same template rendered different epochs depending on the host timezone.{{ "2026-06-30T21:00:00Z" | date: "%s", "America/Toronto" }} before: 1782838800 (on a UTC host) after: 1782853200Changes:
LiquidDate.dateValue()and use it for%s, making it timezone-invariant.Math.round→Math.floorso fractional seconds truncate toward the epoch like Ruby strftime.timezoneOffsetoption, truncation); full suite passes underEtc/GMT,Asia/Shanghai, andAmerica/New_York.%sidentifies an instant and is not affected by the display timezone.