Switch winget publishing to manual PR workflow#22
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughThe pull request modifies the Winget release workflow by disabling automatic pull request creation to the upstream Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Around line 8-17: The changelog's reference links are stale: add a reference
entry for "[0.5.2]" and update the "[Unreleased]" compare link so it no longer
points from "v0.5.1"; specifically, add a link definition for [0.5.2] that
compares v0.5.1...v0.5.2 and adjust the [Unreleased] link target to the new
baseline (e.g., v0.5.2...HEAD or the appropriate repo/commit range) so both
[Unreleased] and [0.5.2] are defined and resolve correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9bfeae65-5176-413e-9a43-36495d59f5bb
📒 Files selected for processing (6)
.goreleaser.yamlCHANGELOG.mddocs/adr/0003-release-and-update-policy.mdtasks/feature_spec.mdtasks/lessons.mdtasks/todo.md
| ## [0.5.2] - 2026-04-04 | ||
|
|
||
| ### Changed | ||
|
|
||
| - winget manifest の公開フローは `harumiWeb/winget-pkgs` fork への push までを自動化し、`microsoft/winget-pkgs` への PR は手動作成に切り替えました。 | ||
|
|
||
| ### Fixed | ||
|
|
||
| - fine-grained PAT で upstream への cross-repository PR 作成が 403 になり、release workflow 全体が失敗する問題を回避しました。 | ||
|
|
There was a problem hiding this comment.
Update changelog reference links for 0.5.2.
After adding Line 8 (0.5.2), the reference block still points [Unreleased] from v0.5.1 and does not define [0.5.2], so generated links become stale/missing.
Suggested fix
-[Unreleased]: https://github.com/harumiWeb/eitango/compare/v0.5.1...HEAD
+[Unreleased]: https://github.com/harumiWeb/eitango/compare/v0.5.2...HEAD
+[0.5.2]: https://github.com/harumiWeb/eitango/compare/v0.5.1...v0.5.2
[0.5.1]: https://github.com/harumiWeb/eitango/compare/v0.5.0...v0.5.1🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CHANGELOG.md` around lines 8 - 17, The changelog's reference links are stale:
add a reference entry for "[0.5.2]" and update the "[Unreleased]" compare link
so it no longer points from "v0.5.1"; specifically, add a link definition for
[0.5.2] that compares v0.5.1...v0.5.2 and adjust the [Unreleased] link target to
the new baseline (e.g., v0.5.2...HEAD or the appropriate repo/commit range) so
both [Unreleased] and [0.5.2] are defined and resolve correctly.
Up to standards ✅🟢 Issues
|
Summary
Why
The v0.5.1 release succeeded through GitHub Releases and fork push, but failed when GoReleaser tried to open a cross-repository PR against microsoft/winget-pkgs with a fine-grained PAT. This change keeps the automated part that works and removes the failing step from the release workflow.
Verification
Summary by CodeRabbit
Changed
Fixed