Skip to content

Add CI lint job and document local vs CI quality gates#25

Merged
harumiWeb merged 3 commits intomainfrom
copilot/ci-integrate-lint-into-ci
Apr 6, 2026
Merged

Add CI lint job and document local vs CI quality gates#25
harumiWeb merged 3 commits intomainfrom
copilot/ci-integrate-lint-into-ci

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 6, 2026

Linting was only enforced through local hooks, which left PR quality dependent on contributor setup. This updates CI to run the required lint checks on every PR and documents how local hooks complement, rather than replace, CI enforcement.

  • CI quality gate

    • Adds a dedicated lint job to the existing CI workflow
    • Runs shellcheck for install.sh
    • Runs golangci-lint for the Go codebase
    • Keeps the existing cross-platform test/build matrix focused on test and build coverage
  • Contributor guidance

    • Updates README.md and README.en.md with the local commands contributors should run
    • Clarifies the role split:
      • lefthook pre-commit = convenience / fast local feedback
      • CI = required enforcement for PRs
    • Adds a simple self-serve path for resolving lint failures locally
  • Workflow shape

    • Separates lint from the OS matrix so PRs get an explicit lint result without duplicating shell lint setup across all runners
jobs:
  lint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-go@v5
      - run: shellcheck install.sh
      - uses: golangci/golangci-lint-action@v8
        with:
          version: v2.11.4

Open with Devin

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 6, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Agent-Logs-Url: https://github.com/harumiWeb/eitango/sessions/e8f38e35-21ed-4f45-a56e-eff592d7136e

Co-authored-by: harumiWeb <164025931+harumiWeb@users.noreply.github.com>
Copilot AI changed the title [WIP] Add lint step to CI for automated quality gate Add CI lint job and document local vs CI quality gates Apr 6, 2026
Copilot AI requested a review from harumiWeb April 6, 2026 10:47
@harumiWeb
Copy link
Copy Markdown
Owner

@copilot codacy ciがエラーになってるから修正して

Agent-Logs-Url: https://github.com/harumiWeb/eitango/sessions/9cfb9b96-0628-4496-add8-4ea416278ea0

Co-authored-by: harumiWeb <164025931+harumiWeb@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 6, 2026

@copilot codacy ciがエラーになってるから修正して

92e25e6 で lint job の GitHub Actions 参照を immutable SHA に固定しました。Codacy が workflow security 系の指摘で落ちている想定への最小修正です。再実行で反映されるはずです。

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • app.codacy.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • https://api.github.com/repos/codacy/codacy-cli-v2/releases/latest
    • Triggering command: /usr/bin/curl curl -Lq REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@harumiWeb harumiWeb marked this pull request as ready for review April 6, 2026 11:48
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@harumiWeb harumiWeb merged commit e90b9c6 into main Apr 6, 2026
8 checks passed
@harumiWeb harumiWeb deleted the copilot/ci-integrate-lint-into-ci branch April 6, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: lint を CI に統合して品質ゲートを自動化する

2 participants