Add CI lint job and document local vs CI quality gates#25
Merged
Conversation
5 tasks
Up to standards ✅🟢 Issues
|
Agent-Logs-Url: https://github.com/harumiWeb/eitango/sessions/e8f38e35-21ed-4f45-a56e-eff592d7136e Co-authored-by: harumiWeb <164025931+harumiWeb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add lint step to CI for automated quality gate
Add CI lint job and document local vs CI quality gates
Apr 6, 2026
Owner
|
@copilot codacy ciがエラーになってるから修正して |
Agent-Logs-Url: https://github.com/harumiWeb/eitango/sessions/9cfb9b96-0628-4496-add8-4ea416278ea0 Co-authored-by: harumiWeb <164025931+harumiWeb@users.noreply.github.com>
Contributor
Author
92e25e6 で lint job の GitHub Actions 参照を immutable SHA に固定しました。Codacy が workflow security 系の指摘で落ちている想定への最小修正です。再実行で反映されるはずです。 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
harumiWeb
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting was only enforced through local hooks, which left PR quality dependent on contributor setup. This updates CI to run the required lint checks on every PR and documents how local hooks complement, rather than replace, CI enforcement.
CI quality gate
lintjob to the existing CI workflowshellcheckforinstall.shgolangci-lintfor the Go codebaseContributor guidance
README.mdandREADME.en.mdwith the local commands contributors should runlefthookpre-commit = convenience / fast local feedbackWorkflow shape