Clean up p9GridSpec: fix axes ownership, inline update, remove dead code#1044
Merged
Clean up p9GridSpec: fix axes ownership, inline update, remove dead code#1044
Conversation
Owner
has2k1
commented
Apr 3, 2026
has2k1
commented
- Add _axes property that filters by gridspec identity, fixing _update_axes_position which previously iterated all figure axes without ownership checks and passed self as the figure argument
- Inline update() into init (direct SubplotParams construction) and update_params_and_artists (explicit field access)
- Remove unused parent_gridspec cached_property
- Replace nested hasattr check with explicit _nested bool flag
- Add _axes property that filters by gridspec identity, fixing _update_axes_position which previously iterated all figure axes without ownership checks and passed self as the figure argument - Inline update() into __init__ (direct SubplotParams construction) and update_params_and_artists (explicit field access) - Remove unused parent_gridspec cached_property - Replace nested hasattr check with explicit _nested bool flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.