Skip to content

Refactor layout manager#1045

Merged
has2k1 merged 7 commits intomainfrom
refactor-layout-manager
Apr 6, 2026
Merged

Refactor layout manager#1045
has2k1 merged 7 commits intomainfrom
refactor-layout-manager

Conversation

@has2k1
Copy link
Copy Markdown
Owner

@has2k1 has2k1 commented Apr 5, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.73%. Comparing base (a1193ad) to head (11aa422).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...e/_mpl/layout_manager/_composition_layout_items.py 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   86.77%   86.73%   -0.05%     
==========================================
  Files         203      203              
  Lines       13819    13761      -58     
  Branches     1706     1692      -14     
==========================================
- Hits        11992    11936      -56     
+ Misses       1276     1274       -2     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@has2k1 has2k1 force-pushed the refactor-layout-manager branch from a0360e2 to 4bd2378 Compare April 5, 2026 07:51
Only the figure creator should own the layout engine. Moving
set_layout_engine into _create_figure() ensures this — the existing
hasattr(self, "figure") guard prevents embedded plots/compositions
from setting it.
@has2k1 has2k1 merged commit 11aa422 into main Apr 6, 2026
14 checks passed
@has2k1 has2k1 deleted the refactor-layout-manager branch April 6, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant