Update to 0.17, use official winit backend#18
Open
Skelebot wants to merge 2 commits into
Open
Conversation
oldwomanjosiah
left a comment
oldwomanjosiah
left a comment
There was a problem hiding this comment.
Thank you for adding this, it was a life-saver!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe it's better to use the official backend in this example and create a different example for the egui_winit_platform crate (or deprecate the crate entirely in favor of a single implementation in the ecosystem, especially that both crates are very similar).
I also believe that this example should live inside the egui_wgpu_backend repo (as a cargo example in a /examples folder).
Discussion is welcome.