Walk: add support for go1.20 multi errors (Unwrap() []error)#18
Draft
dolmen wants to merge 1 commit intohashicorp:masterfrom
Draft
Walk: add support for go1.20 multi errors (Unwrap() []error)#18dolmen wants to merge 1 commit intohashicorp:masterfrom
dolmen wants to merge 1 commit intohashicorp:masterfrom
Conversation
dolmen
changed the title
Author
|
I'll work on tests once #17 is merged. |
Author
dnephin
reviewed
Mar 23, 2024
Contributor
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
Hello, thank you for the PR! I am no longer a maintainer on this project, so I can't give you an official response.
I believe this change is correct. Unwrap() []error is supported by the standard library, so it seems reasonable that the Walk function would also support it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walknow also handles errors wrapped with go1.20errors.Join.A note is also added in the documentation of interface
Wrapperto suggest usingUnwrap() []error.