feat: Add support for logging with context#231
feat: Add support for logging with context#231whrss9527 wants to merge 14 commits intohashicorp:mainfrom
Conversation
|
|
|
I want to make the logging code as concise and brief as possible, while ensuring the API is user-friendly and compatible with mainstream Golang logging frameworks, such as the increasingly common slog. If you have a better implementation, I am open to learning. |
|
@Ehco1996 Sorry, I clicked by mistake |
reedip
left a comment
reedip
left a comment
There was a problem hiding this comment.
In line #445 in the new code, the comment states that the Custom Logger can be Logger or Leveled Logger. Maybe that can be changed?
This is just a nit, and mainly because I was trying to go through this Client structure and found it.
|
could this be merged pls? |
|
Please merge this in. |
|
I'm also interested in this. Can this be merged? I'm glad to help if anything is missing. |
|
I'm also interested in this. Can this be merged ? |
7 participants
Add support for logging with context, you can pass slog to NewContextLogger to print trace or other log information.
#182