fix: skip default restart check when custom restart_check_command is provided#13654
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: skip default restart check when custom restart_check_command is provided#13654AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…provided When a user provides a custom restart_check_command to the windows-restart provisioner, the DefaultRestartCheckCommand (which uses [System.Net.Dns]::GetHostName()) was still being executed afterward. This breaks Windows Constrained Language Mode because that .NET call is not allowed in constrained mode. Fix: when a custom restart_check_command is provided, skip the default PowerShell module-load check entirely. The user's custom command is sufficient to verify the restart. Fixes hashicorp#13643
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
1 similar comment
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The windows-restart provisioner runs DefaultRestartCheckCommand ([System.Net.Dns]::GetHostName()) even when the user provides a custom restart_check_command. This breaks Windows Constrained Language Mode because the .NET call is not allowed in constrained mode.
Root cause
In waitForCommunicator, the runCustomRestartCheck flag was set to false when using the default command, but after running the custom check, it was set to false again (line 239 old), causing the default check to always run afterward.
What I changed
Fixes #13643