Add support for testing FPE transformations#269
Open
rculpepper wants to merge 3 commits into
Open
Conversation
davidquirozibm
self-requested a review
July 17, 2026 19:22
davidquirozibm
previously approved these changes
Jul 17, 2026
davidquirozibm
left a comment
davidquirozibm
left a comment
Contributor
There was a problem hiding this comment.
Hello @rculpepper this test looks really good! I only found one small documentation discrepancy as a minor nitpick. Thank you for helping improve the Vault benchmark!
| FPEConfig: &TransformFPEConfig{ | ||
| Name: "benchmarktransformation", | ||
| Template: "builtin/creditcardnumber", | ||
| TweakSource: "internal", |
Contributor
There was a problem hiding this comment.
Here the TweakSource default is listed as internal (this is correct! it should be internal by default)
Author
There was a problem hiding this comment.
I changed this one to "supplied," since that matches the default in Transform
| A list of template names to use for matching. Mutually exclusive with | ||
| `template`. When provided, the first matching template is used. | ||
|
|
||
| - `tweak_source` `(string: "supplied")` - |
Contributor
There was a problem hiding this comment.
Here TweakSource default is listed as supplied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config and docs for testing FPE transformations