BE-583, BE-584, BE-586: HashQL: Add HeapPool, improve spans, and propagate Critical severity through diagnostics

libs/@local/graph/api/src/rest/entity_query_request.rs

@@ -51,7 +51,6 @@ use hashql_diagnostics::{
     DiagnosticIssues, Failure, Severity, Status, StatusExt as _, Success,
     category::{DiagnosticCategory, canonical_category_id},
     diagnostic::render::{Format, RenderOptions},
-    severity::Critical,
     source::{DiagnosticSpan, Source, SourceId, Sources},
 };
 use hashql_eval::{
@@ -340,19 +339,7 @@ impl<'q> EntityQuery<'q> {
         let mut ast = parser
             .parse_expr(query.get().as_bytes())
             .map_err(|diagnostic| {
-                Failure::new(
-                    diagnostic
-                        .map_category(HashQLDiagnosticCategory::JExpr)
-                        .map_severity(|severity| {
-                            Critical::try_new(severity).unwrap_or_else(|| {
-                                tracing::error!(
-                                    ?severity,
-                                    "JExpr returned an error of non-critical severity"
-                                );
-                                Critical::ERROR
-                            })
-                        }),
-                )
+                Failure::new(diagnostic.map_category(HashQLDiagnosticCategory::JExpr))
             })?;
 
         let mut env = Environment::new(heap);

libs/@local/hashql/compiletest/src/pipeline.rs

@@ -130,6 +130,7 @@ impl<'heap> Pipeline<'heap> {
 
         parser
             .parse_expr(content.as_ref())
+            .map_err(Diagnostic::generalize)
             .map_err(Diagnostic::boxed)
     }
 

libs/@local/hashql/core/Cargo.toml

@@ -32,7 +32,7 @@ lexical              = { workspace = true, features = ["parse-integers", "parse-
 memchr               = { workspace = true }
 rapidfuzz            = { workspace = true }
 roaring              = { workspace = true, features = ["std"] }
-rpds                 = { workspace = true, features = ["std"] }
+rpds                 = { workspace = true }
 serde                = { workspace = true, optional = true, features = ["alloc", "derive"] }
 simple-mermaid       = { workspace = true }
 tracing              = { workspace = true }

libs/@local/hashql/core/src/collections/pool.rs

@@ -344,6 +344,7 @@ where
     /// let pool = VecPool::<i32>::new(15);
     /// assert_eq!(pool.capacity(), 15);
     /// ```
+    #[inline]
     pub const fn capacity(&self) -> usize {
         self.capacity
     }

libs/@local/hashql/core/src/graph/algorithms/dominators/frontier.rs

@@ -177,6 +177,7 @@ where
     }
 
     /// Returns the underlying [`RowRef`] if the frontier is non-empty.
+    #[inline]
     #[must_use]
     pub const fn as_inner(&self) -> Option<RowRef<'_, N>> {
         self.inner

libs/@local/hashql/core/src/heap/mod.rs

@@ -111,7 +111,7 @@ pub use self::{
     clone::{CloneIn, TryCloneIn},
     convert::{FromIn, IntoIn},
     iter::{CollectIn, FromIteratorIn},
-    pool::{ScratchPool, ScratchPoolGuard},
+    pool::{HeapPool, HeapPoolGuard, ScratchPool, ScratchPoolGuard},
     scratch::Scratch,
     transfer::TransferInto,
 };
@@ -288,6 +288,7 @@ impl Heap {
 }
 
 impl Default for Heap {
+    #[inline]
     fn default() -> Self {
         Self::new()
     }