waitReply and rawUnary credit the connection#46
Open
abizjak wants to merge 15 commits into
Open
Conversation
This currently requires the updated version of http2-client available at https://github.com/abizjak/http2-client
Member
|
Thanks, I think Travis needs to wait for a release on Hackage for the patched http2-client. Will do that tomorrow and retry here. Longer term I think I'll revamp the gRPC client helper to have a bit more "configurable" behaviors. Hopefully in 2021 I'll get some time to work on this. |
10 tasks
pcapriotti
added a commit
to wireapp/wire-server
that referenced
this pull request
Sep 24, 2021
We now depend on a fork of http2-grpc-haskell containing fixes for: haskell-grpc-native/http2-grpc-haskell#46 haskell-grpc-native/http2-grpc-haskell#48 as well as the master of http2-client: https://github.com/lucasdicioccio/http2-client
4 tasks
pcapriotti
added a commit
to wireapp/wire-server
that referenced
this pull request
Sep 28, 2021
* Merge http2 grpc fixes We now depend on a fork of http2-grpc-haskell containing fixes for: haskell-grpc-native/http2-grpc-haskell#46 haskell-grpc-native/http2-grpc-haskell#48 as well as the master of http2-client: https://github.com/lucasdicioccio/http2-client * Clarify comment about http2-client fixes Co-authored-by: jschaul <jschaul@users.noreply.github.com>
…encies Updates ghc version to `9.0.2` and stackage version to `lts-19.6`.
5 tasks
Credit the connection as well when streaming.
Terminate when encountering end of stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on haskell-grpc-native/http2-client#75
The change in the functionality of
waitStreammeans thatrawUnaryqueries do not rely on the background thread sending WINDOW_UPDATE frames to progress. This makes them perform with much lower latency in some scenarious.