Hlint: suggest nub alternative#11825
Merged
mergify[bot] merged 1 commit intoMay 26, 2026
Merged
Conversation
2 tasks
jappeace
reviewed
May 14, 2026
Bodigrim
reviewed
May 14, 2026
Bodigrim
reviewed
May 14, 2026
philderbeast
force-pushed
the
hlint/suggest-nub-alternatives
branch
2 times, most recently
from
a350dda to
d7a010b
Compare
Bodigrim
approved these changes
May 21, 2026
philderbeast
force-pushed
the
hlint/suggest-nub-alternatives
branch
from
d7a010b to
1d0950b
Compare
philderbeast
added
merge me
philderbeast
force-pushed
the
hlint/suggest-nub-alternatives
branch
from
1d0950b to
d1dcf19
Compare
mergify
Bot
added
the
ready and waiting
- Use single letter variables with hlint rules - Only suggest ordNub - Add growth rate note - Include necessary imports - Follow hlint suggestion: use ordNub - Follow hlint suggestion: use ordNub in tests - Satisfy hlint: use fewer imports - Add @SInCE annotations for added Ord instances
philderbeast
force-pushed
the
hlint/suggest-nub-alternatives
branch
from
d1dcf19 to
64d8543
Compare
Collaborator
Author
|
@mergify queue |
Contributor
Merge Queue Status
This pull request spent 1 hour 34 minutes 47 seconds in the queue, including 1 hour 24 minutes 11 seconds running CI. Waiting for any of
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
86 tasks
Collaborator
Author
|
@mergify queue |
Contributor
Merge Queue Status
This pull request spent 11 minutes 57 seconds in the queue, including 40 seconds running CI. Waiting for
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks:
HintYou may have to fix your CI before adding the pull request to the queue again. |
86 tasks
Collaborator
Author
|
GitHub CI is being flaky: |
Collaborator
Author
|
@mergify queue |
Contributor
Merge Queue Status
This pull request spent 1 hour 55 minutes 42 seconds in the queue, including 1 hour 44 minutes 11 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11824.
When fired, this suggestion renders as:
I didn't correct
O(n log n)to theO(n log d)from containers haddocks fornubOrd. Neither did I suggest using that equivalent function from containers. For that, I raised #11826.I had to add
Ordinstances to a few data types,BuildTargetandMatchError. I changed theEqconstraint to anOrdconstraint forfindMatchandnubMatches.I left a note in
.hlint.yamlto only use single letter variables in rules.I used a separate commit for changes to tests but on approval will squash all commits before adding the
merge melabel.