Monitor imported cabal.project files#11884
Draft
philderbeast wants to merge 3 commits into
Draft
Conversation
- Fixes haskell#10255 - Fix assertion failure wrt haskell#11568 'lookupLocalPackageConfig' would ignore --'projectConfigAllPackages' (`package *`) and thus diverge from 'lookupPerPkgOption'. This would then cause further divergence between 'elabStanzasRequested' and 'elabStanzasAvailable'. - Add test for haskell#10255 - Add bootstrap-jsons-ghcup Makefile rule - Be stricter about URI imports - This behavior is documented, but not enforced. We redesign the 'ProjectConfigPath' type to better express the properties we expect. - Revert Cabal-syntax network-uri - Revert boostrap/*.json and Makefile - Revert ProjectConfigPath - Revert ParserTests - Revert ProjectConfig/[Legacy|Parsec] - Revert Compat/Orphans - Revert TreeDiffInstances - Revert deletion of ProjectFileParseError - Revert Arbitrary ProjectConfigProvenance change - Revert Errors/Parser prettyShow removal - Get ProjectConfig compiling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started with #11567 by @hasufell.
I then reverted a lot of changes not related to (or no longer needed for) monitoring before attempting a rebase. To make the rebase easier I also squashed those changes into one commit.
I then rebased over master once #10933 merged, so that we could match on whether an import was local file or a URI.
Important
This is a draft.
-Wunused-top-bindsforlookupLocalPackageConfig.significance: significantin the changelog file.