Decomission build-type: Make#11894
Open
Bodigrim wants to merge 2 commits into
Open
Conversation
Bodigrim
force-pushed
the
decomission-build-type-make
branch
2 times, most recently
from
212ab3b to
c94f9b1
Compare
zlonast
reviewed
May 27, 2026
zlonast
approved these changes
May 27, 2026
It's been broken at least since Cabal 3.4, which is 7 releases back, and no one ever complained. That's been enough of "deprecation" period ;) (One of the reasons it was broken is that `Distribution.Make.buildAction` is from the epoch when Cabal packages didn't have any components and mandates `noExtraFlags`, while the rest of Cabal expects that `buildAction` should be able to take a component target and supplies one by default, even if a user didn't.) The only Hackage package, whose latest release uses `build-type: Make`, is `lvmrun`: last released in 2014 and long broken because of the above.
Bodigrim
force-pushed
the
decomission-build-type-make
branch
from
c94f9b1 to
1a3ed1b
Compare
ulysses4ever
approved these changes
May 28, 2026
Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
mergify
Bot
added
the
ready and waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11610.
build-type: Makehas been broken at least since Cabal 3.4, which is 7 releases back, and no one ever complained. That's been enough of "deprecation" period ;)(One of the reasons it was broken is that
Distribution.Make.buildActionis from the epoch when Cabal packages didn't have any components and mandatesnoExtraFlags, while the rest of Cabal expects thatbuildActionshould be able to take a component target and supplies one by default, even if a user didn't.)The only Hackage package, whose latest release uses
build-type: Make, islvmrun: last released in 2014 and long broken because of the above.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.