Make it compile with MicroHs #257
Merged
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
Oct 4, 2025
System/OsPath/Common.hs
Outdated
| , PS.unsafeEncodeUtf | ||
| , PS.encodeWith | ||
| , encodeFS | ||
| #if !defined(__MHS__) |
Contributor
There was a problem hiding this comment.
I think it's more idiomatic to write #ifdef MIN_VERSION_template_haskell: we don't really care MHS or not, we care if it has TH (and, in glorious future, more specifically template-haskell-quasiquoter).
Contributor
Author
There was a problem hiding this comment.
Yes, that is a better way.
Contributor
Author
There was a problem hiding this comment.
I've made some updates to minimize the changes.
konsumlamm
suggested changes
Jan 6, 2026
|
|
||
|
|
||
|
|
||
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) |
There was a problem hiding this comment.
Suggested change
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) | |
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasiquoter) |
The package is called template-haskell-quasiquoter.
Comment on lines
+169
to
+170
| osp = error "Systen.OsPath.Internal.ostr: no Template Haskell" | ||
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) */ |
There was a problem hiding this comment.
Suggested change
| osp = error "Systen.OsPath.Internal.ostr: no Template Haskell" | |
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) */ | |
| osp = error "System.OsPath.Internal.ostr: no Template Haskell" | |
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasiquoter) */ |
|
|
||
| #include "Common.hs" | ||
|
|
||
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) |
There was a problem hiding this comment.
Suggested change
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) | |
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasiquoter) |
Comment on lines
+35
to
+36
| pstr = error "Systen.OsPath.Posix.pstr: no Template Haskell" | ||
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) */ |
There was a problem hiding this comment.
Suggested change
| pstr = error "Systen.OsPath.Posix.pstr: no Template Haskell" | |
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) */ | |
| pstr = error "System.OsPath.Posix.pstr: no Template Haskell" | |
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasiquoter) */ |
| #include "Common.hs" | ||
|
|
||
|
|
||
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) |
There was a problem hiding this comment.
Suggested change
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) | |
| #if defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasiquoter) |
Comment on lines
+35
to
+36
| pstr = error "Systen.OsPath.Windows.pstr: no Template Haskell" | ||
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) */ |
There was a problem hiding this comment.
Suggested change
| pstr = error "Systen.OsPath.Windows.pstr: no Template Haskell" | |
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasi_quoter) */ | |
| pstr = error "System.OsPath.Windows.pstr: no Template Haskell" | |
| #endif /* defined(MIN_VERSION_template_haskell) || defined(MIN_VERSION_template_haskell_quasiquoter) */ |
Comment on lines
+102
to
+104
| if impl(mhs) | ||
| build-depends: | ||
| ghc-compat |
There was a problem hiding this comment.
I think this isn't necessary anymore? @augustss
Contributor
Author
There was a problem hiding this comment.
No, ghc-compat is implicit now.
Member
|
@augustss did you see the new review comments? |
Member
|
I'm fixing up the remaining issues |
Member
|
this is uploaded to hackage as 1.5.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title say it all.