Skip to content

Support symbolic record fields when converting to record syntax#4978

Merged
fendor merged 2 commits into
haskell:masterfrom
olaberglund:ola/push-szylsvulzzxv
Jun 18, 2026
Merged

Support symbolic record fields when converting to record syntax#4978
fendor merged 2 commits into
haskell:masterfrom
olaberglund:ola/push-szylsvulzzxv

Conversation

@olaberglund

@olaberglund olaberglund commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Closes #4975

If the field name consists of symbolic characters, add surrounding parentheses before rendering inlay hint or field with argument when converting to record syntax.

Extended relevant test case to feature a record field made up of symbolic characters.

@olaberglund olaberglund requested a review from ozkutuk as a code owner June 17, 2026 20:26

@fendor fendor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the test failures ;)

@olaberglund olaberglund force-pushed the ola/push-szylsvulzzxv branch 2 times, most recently from f530e58 to 17fe512 Compare June 18, 2026 18:51
@fendor fendor force-pushed the ola/push-szylsvulzzxv branch from 17fe512 to b1ff9fd Compare June 18, 2026 19:54
@fendor fendor enabled auto-merge (squash) June 18, 2026 19:54
@fendor fendor merged commit 77304e8 into haskell:master Jun 18, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert to record syntax wrong for operator fields

2 participants