Feat: Link favourite images with campaign#364
Open
ItsAbhinavM wants to merge 1 commit intohatnote:masterfrom
Open
Feat: Link favourite images with campaign#364ItsAbhinavM wants to merge 1 commit intohatnote:masterfrom
ItsAbhinavM wants to merge 1 commit intohatnote:masterfrom
Conversation
Contributor
Author
|
The changes made are purely on backend, but in case if any one wants to add this in front-end for any future works I have also created a jurorService end-point for fetching favorite images. |
Contributor
Author
|
@mahmoud can you review this and tell me whether this requires any more changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #148
This PR intends to link favorite images of a round with their respective campaigns.
Earlier favorite were associated only with juror and entry, which made it inaccessible in a campaign.
campaign_idis now added on each new favorite images. Thefave()andunfave()functions have been adjusted accordingly to prevent any cross-campaign-collissions.In addition active favorites can be now retrieved from campaign.