Address review feedback on Phase 4 underwater medium tracking without expanding scope#209
Draft
Copilot wants to merge 1 commit into
Draft
Address review feedback on Phase 4 underwater medium tracking without expanding scope#209Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
8 tasks
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on editor_params bug in underwater medium tracking PR
Address review feedback on Phase 4 underwater medium tracking without expanding scope
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stacked PR resolves review feedback on the Phase 4 underwater-medium work while keeping the
editor_paramshost/shader mismatch explicitly out of scope (it is pre-existing from PR #201). The branch focuses on correctness of water-state seeding/layout and clarifies shader behavior boundaries.Host-side water-plane classification fix
dot(n, p) + d = 0.water_state.xcorrectly.Push/cbuffer alignment intent preserved
water_stateat the intended offset for Phase 4 medium tracking.editor_paramshost-struct expansion in this PR.Shader documentation cleanup (behavioral scope)
in_watercomments to match implementation: Phase 4 toggles onMAT_WATERrefract path only.