refactor(Phonology): tidy Tone/Constraints.lean docstring + variables#575
Merged
Conversation
hawkrobe
force-pushed
the
tone-constraints-tidy
branch
from
6d204d3 to
e323878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidy the tonal-constraints file: restructure the module docstring into mathlib shape (
# / ## Main definitions / ## Implementation notes), lift the per-constraint form(f : FloatingForm S TRN)to a section variable (dedups it across 11 predicate helpers/instances), bundle{S : Type*}, and convert the§Nbanner comments to/-! ### -/dividers.Also corrects a citation bug:
*CROWDwas attributed to [cahill-2004], but the Poko paper credits the stem-not-TBU tone ceiling to Hyman & VanBik and cites Cahill only for toneless-syllable avoidance — so the misattribution is dropped (the constraint is McPherson's own, paper eq. 5).