Fix from-source update-check TLS error + reveal imported video's folder (v1.9.0)#104
Merged
Conversation
hayhamLT
changed the title
hayhamLT
force-pushed
the
claude/modest-wright-6lljus
branch
from
77ef464 to
6d53146
Compare
hayhamLT
changed the title
…er (v1.9.0) certifi was only a build dependency, so running from source on a Python with an empty trust store failed the GitHub update check with CERTIFICATE_VERIFY_FAILED. Make it a runtime dependency (requirements + pyproject), have ca_bundle_path() also honour SSL_CERT_FILE / REQUESTS_CA_BUNDLE for locked-down machines, and point the update-failure dialog at the fix. Two resolver tests cover the order (certifi preferred, env fallback). Add a Reveal in Finder/Explorer action to the imported-video right-click menu so a clip's source folder is one click away. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F3rfxvrhYUyjTsifsuJw9s
hayhamLT
force-pushed
the
claude/modest-wright-6lljus
branch
from
6d53146 to
bc563d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, focused changes on top of the PrevizRender rebrand (already merged via #106), plus the version bump to v1.9.0.
Certificate fix — the auto-update SSL error
certifiwas only a build dependency, so running from source on a Python with an empty trust store failed the update check withCERTIFICATE_VERIFY_FAILED. It's now a runtime dependency (requirements.txt+pyproject.toml);ca_bundle_path()also honoursSSL_CERT_FILE/REQUESTS_CA_BUNDLEso a locked-down machine can supply its own bundle without a rebuild; and the update-failure dialog now points at the fix (pip install certifi). Installed/frozen builds already ship a CA bundle, so this only ever bit from-source runs.Two resolver tests cover the order — certifi preferred, env-var fallback (guarded with
importorskipso CI's tooling-only lint job skips cleanly).Reveal in Finder for imported videos
Right-click an imported clip → Reveal in Finder / Explorer / File Manager opens its source folder. Only shown for real clips (not the "Add Videos…" placeholder), with the folder path as a tooltip.
Verification
ruffcleanmypyclean over the full tree (83 files, mypy 2.1.0 — matches CI)tests/test_utils.pygreen incl. the two new resolver tests🤖 Generated with Claude Code
https://claude.ai/code/session_01F3rfxvrhYUyjTsifsuJw9s