Require explicit status input for Slack notification action#79
Open
JackPGreen wants to merge 1 commit into
Open
Require explicit status input for Slack notification action#79JackPGreen wants to merge 1 commit into
status input for Slack notification action#79JackPGreen wants to merge 1 commit into
Conversation
The workflow attempts to derive the enclosing job status, to report success/failure without being explicitly told. However, this doesn't seem to work properly, e.g. in this example, it's only triggered on `failure()`: https://github.com/hazelcast/mono-actions/blob/f4d06085c5c0089ad76a475e067a4fc096adab25/copybara/copy-commit-to-os/action.yaml#L88-89 And yet the [job logs](https://github.com/hazelcast/hazelcast-mono/actions/runs/29821335563/job/88623379973#step:3:1549) show the `job.status` as `success`. actions/runner#1682 relates to a _similar_ issue where it's suggested the status is not always updated "live" in composite actions. The simplest solution is to require an _explicit_ input rather than deriving.
JackPGreen
added a commit
to hazelcast/mono-actions
that referenced
this pull request
Jul 21, 2026
JackPGreen
added a commit
to JackPGreen/hazelcast-docs
that referenced
this pull request
Jul 21, 2026
|
JackPGreen
added a commit
to hazelcast/dependabot-automerge
that referenced
this pull request
Jul 21, 2026
This was referenced Jul 21, 2026
JackPGreen
added a commit
to hazelcast/hazelcast-docs
that referenced
this pull request
Jul 21, 2026
nishaatr
approved these changes
Jul 22, 2026
Comment on lines
9
to
+10
| status: | ||
| description: The status to set, otherwise inherited from the enclosing job | ||
| required: false | ||
| description: The status to set (`success` or `failure`) |
Contributor
There was a problem hiding this comment.
nit
I see in test-slack-notification.yml passing ''
which is fine but perhaps document that any other value is marked as failure
Contributor
|
Just saw https://github.com/hazelcast/monorepo-utils/pull/5/changes why not make it default |
JackPGreen
added a commit
to hazelcast/dependabot-automerge
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow attempts to derive the enclosing job status, to report success/failure without being explicitly told.
However, this doesn't seem to work properly, e.g. in this example, it's only triggered on
failure(): https://github.com/hazelcast/mono-actions/blob/f4d06085c5c0089ad76a475e067a4fc096adab25/copybara/copy-commit-to-os/action.yaml#L88-89And yet the job logs show the
job.statusassuccess.actions/runner#1682 relates to a similar issue where it's suggested the status is not always updated "live" in composite actions.
The simplest solution is to require an explicit input rather than deriving.