Skip to content

Harden curl usage - add retries and error logging #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackPGreen merged 1 commit into from
Jul 8, 2026
Merged

Harden curl usage - add retries and error logging #1484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ jobs:

- name: Check formatting
run: |
source /dev/stdin <<< "$(curl --fail --silent https://raw.githubusercontent.com/hazelcast/github-actions-common-scripts/main/logging.functions.sh)"
source /dev/stdin <<< "$(curl --fail --retry 5 --retry-all-errors --show-error --silent https://raw.githubusercontent.com/hazelcast/github-actions-common-scripts/main/logging.functions.sh)"

git-clang-format \
${{ needs.get-refs.outputs.base-sha }} \
Expand Down
2 changes: 1 addition & 1 deletion scripts/install-boost.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ fi

TARBALL_NAME=boost_$(echo "$1" | tr . _)

curl --fail --silent --show-error --location "https://archives.boost.io/release/${1}/source/${TARBALL_NAME}.tar.gz" | tar xzf -
curl --fail --retry 5 --retry-all-errors --show-error --silent --show-error --location "https://archives.boost.io/release/${1}/source/${TARBALL_NAME}.tar.gz" | tar xzf -
pushd "${TARBALL_NAME}"
./bootstrap.sh
# Build the libs for:
Expand Down
2 changes: 1 addition & 1 deletion scripts/install-thrift.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ fi
# Ideally we would download directly from Apache:
# https://www.apache.org/dyn/closer.lua/thrift/$1/thrift-$1.tar.gz?action=download
# But this has intermittent failures in GitHub Actions
curl --fail --silent --show-error --location "https://deb.debian.org/debian/pool/main/t/thrift/thrift_$1.orig.tar.gz" | tar xzf -
curl --fail --retry 5 --retry-all-errors --show-error --silent --show-error --location "https://deb.debian.org/debian/pool/main/t/thrift/thrift_$1.orig.tar.gz" | tar xzf -
pushd thrift-$1/build
cmake .. -DBUILD_COMPILER=OFF -DBUILD_TESTING=OFF -DBUILD_TUTORIALS=OFF -DBUILD_LIBRARIES=ON \
-DBUILD_CPP=ON -DBUILD_AS3=OFF -DBUILD_C_GLIB=OFF -DBUILD_JAVA=OFF -DBUILD_PYTHON=OFF \
Expand Down
Loading