Skip to content

fix(profile): add about character counter #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JhonataSnts wants to merge 4 commits into
base: 4.x
Choose a base branch
from
+19 −0
Open

fix(profile): add about character counter #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28887d6
fix(profile): add about character counter
JhonataSnts Jul 15, 2026
85f62db
Merge branch '4.x' into fix/426-profile-about-character-counter
danielhe4rt Jul 18, 2026
c08f6d9
fix(profile): simplify about character counter
JhonataSnts Jul 20, 2026
5833cf9
fix(profile): reduce about counter livewire updates
JhonataSnts Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app-modules/panel-app/src/Pages/ProfilePage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use Filament\Schemas\Components\Section;
use Filament\Schemas\Components\Utilities\Get;
use Filament\Schemas\Components\Utilities\Set;
use Filament\Schemas\JsContent;
use Filament\Schemas\Schema;
use Filament\Support\Enums\Width;
use He4rt\Gamification\Character\Models\Character;
Expand Down Expand Up @@ -131,6 +132,7 @@ public function form(Schema $schema): Schema
Textarea::make('about')
->label(__('panel-app::profile.fields.about'))
->placeholder(__('panel-app::profile.placeholders.about'))
->hint(JsContent::make('`${Array.from($state ?? "").length}/500`'))
->maxLength(500)
->rows(4)
->live(onBlur: true)
Comment thread
gvieira18 marked this conversation as resolved.
Expand Down
17 changes: 17 additions & 0 deletions app-modules/panel-app/tests/Feature/ProfilePageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

use Filament\Facades\Filament;
use Filament\Forms\Components\Select;
use Filament\Forms\Components\Textarea;
use Filament\Schemas\JsContent;
use He4rt\Identity\User\Models\User;
use He4rt\PanelApp\Pages\ProfilePage;
use He4rt\Profile\Enums\EmploymentType;
Expand Down Expand Up @@ -185,6 +187,21 @@
->assertHasFormErrors(['about']);
});

test('profile page shows about character counter in real time', function (): void {
livewire(ProfilePage::class)
->fillForm([
'about' => 'abc'."\u{1F600}".'def',
])
->assertFormFieldExists('about', function (Textarea $field): bool {
expect($field->getHint())->toBeInstanceOf(JsContent::class)
->and($field->getHint()->toHtml())->toContain('Array.from($state')
->toContain('500')
->and($field->getStateBindingModifiers())->toBe(['live', 'blur']);

return true;
});
});

test('profile page validates headline max length', function (): void {
livewire(ProfilePage::class)
->fillForm([
Expand Down