Open
Conversation
pranavm7
commented
Apr 29, 2022
Comment on lines
+6
to
+16
| /** | ||
| * A class to represent recipes | ||
| * | ||
| * This class serializes the JSON from IRecipeDAO and parses it into a kotlin object | ||
| * @property recipeID | ||
| * @property name Name of the recipe | ||
| * @property category Category of the recipe | ||
| * @property cuisine Cuisine of the recipe | ||
| * @property instructions Instructions of how to create the recipe | ||
| * @property imageURL URL of the image associated with the recipe | ||
| */ |
Collaborator
Author
There was a problem hiding this comment.
Added documentation to the data class.
pranavm7
commented
Apr 29, 2022
Comment on lines
+71
to
+73
| /** | ||
| * Fetches recipes from IRecipeDAO and adds it to an arraylist | ||
| */ |
Collaborator
Author
There was a problem hiding this comment.
Added comments to provide context for the function
pranavm7
commented
Apr 29, 2022
Comment on lines
-3
to
-7
| /** | ||
| * Ingredient mapping service interface that has 2 functions | ||
| * [stringToMap] converts a string into a map | ||
| * [mapToString] converts a map to a string | ||
| */ |
Collaborator
Author
There was a problem hiding this comment.
Please ignore these deletions, seems like the merge caused accidental deletions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deny the deletions in IngredientMapService.kt as it was a fault with the rebase. However my commits are the additional comments I've added.
My code Review.
Does the program compile : circle ci fails.
Was the program available in UC Github on time: Yes
Is the program documented/commented well enough for you to understand: Insufficient, hence my suggestions are comments.
What I learned from this Code Review -
Commits to my project: