fix(cloudformation): resolve stacks by ARN in addition to name#148
Open
sagi-shimoni wants to merge 1 commit intohectorvent:mainfrom
Open
fix(cloudformation): resolve stacks by ARN in addition to name#148sagi-shimoni wants to merge 1 commit intohectorvent:mainfrom
sagi-shimoni wants to merge 1 commit intohectorvent:mainfrom
Conversation
CloudFormation APIs like DescribeStacks, DescribeStackEvents, and DeleteStack now accept a stack ARN as the StackName parameter, matching real AWS behavior. A new resolveStack helper extracts the stack name from the ARN and falls back to a linear scan by stackId. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Hi @sagi-shimoni, Thanks for taking the time to contribute! We've seen your PR and will take a look soon. To ensure this implementation stays robust, could you also open a PR in our compatibility suite at https://github.com/hectorvent/floci-compatibility-tests? This helps us validate that your changes keep working perfectly as the project evolves. The Floci team |
hectorvent
added
cloud-formation
bug
|
Can confirm the bug. As per AWS Documentation the --stack-name filter should also accept the ARN 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DescribeStacks,DescribeStackEvents,DeleteStack) now accept a stack ARN as theStackNameparameter, matching real AWS behaviorresolveStackhelper that extracts the stack name from the ARN and falls back to a linear scan bystackIdresolveStackto avoid inconsistent behaviorTest plan
describeStackEvents_byArnintegration test that creates a stack, captures the ARN, and verifies bothDescribeStackEventsandDescribeStackswork when called with the ARNCloudFormationIntegrationTestsuite (CI)🤖 Generated with Claude Code