feat: support GenerateSecretString and Description for AWS::SecretsManager::Secret in CloudFormation#176
Open
yoyo-real wants to merge 3 commits intohectorvent:mainfrom
Conversation
…nager::Secret in CloudFormation - Extract password generation logic into RandomPasswordGenerator utility - Refactor SecretsManagerJsonHandler to delegate to RandomPasswordGenerator - Update CloudFormationResourceProvisioner.provisionSecret() to handle: - GenerateSecretString (plain password and SecretStringTemplate+GenerateStringKey) - Description property - Add 19 unit tests for RandomPasswordGenerator - Add 9 CloudFormation integration tests for Secrets Manager scenarios
AWS CloudFormation rejects templates that specify both SecretString and GenerateSecretString on AWS::SecretsManager::Secret. Throw AwsException(ValidationError, 400) instead of silently preferring SecretString. Update integration test to verify CREATE_FAILED.
…er-generate-secret-string # Conflicts: # src/test/java/io/github/hectorvent/floci/services/cloudformation/CloudFormationIntegrationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
GenerateSecretStringandDescriptionsupport toAWS::SecretsManager::Secretin the CloudFormation provisioner.Previously,
provisionSecret()only readNameandSecretString. This PR enables:secretsmanager.GetRandomPassword{"username":"admin","password":"<generated>"})SecretsManagerService.createSecret()SecretStringandGenerateSecretStringwithValidationError(400), matching real AWS CloudFormation behaviorAlso extracts password generation into a reusable
RandomPasswordGeneratorutility and refactorsSecretsManagerJsonHandler.handleGetRandomPasswordto delegate to it, eliminating code duplication.Closes #170
Type of change
fix:)feat:)feat!:orfix!:)AWS Compatibility
add floci-compatibility-tests
Checklist
./mvnw testpasses locally