fix(s3): parse S3 notification filter rules instead of failing on nested XML#180
Closed
mtpettyp wants to merge 1 commit intohectorvent:mainfrom
Closed
fix(s3): parse S3 notification filter rules instead of failing on nested XML#180mtpettyp wants to merge 1 commit intohectorvent:mainfrom
mtpettyp wants to merge 1 commit intohectorvent:mainfrom
Conversation
XmlParser.extractGroupsMulti() called getElementText() on every direct child element, which throws on nested elements like <Filter>. The exception was silently caught, causing the entire notification config to be dropped. Replace getElementText() with helpers that traverse nested elements and extract <Name>/<Value> pairs from <FilterRule> blocks. Add filterPrefix and filterSuffix fields to QueueNotification and TopicNotification records, and apply prefix/suffix matching in fireNotifications(). Closes hectorvent#179 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mtpettyp
changed the title
Author
Owner
|
Hi @mtpettyp thanks, I will take a look at of them. Thank you again. |
Owner
|
@mtpettyp Closing this one, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
XmlParser.extractGroupsMulti()andextractGroups()to handle nested elements like<Filter>instead of callinggetElementText()which throws on non-text children. AddfilterPrefix/filterSuffixfields to notification records and apply prefix/suffix matching infireNotifications().Closes #179
Type of change
fix:)feat:)feat!:orfix!:)AWS Compatibility
PutBucketNotificationConfigurationwith<Filter><S3Key><FilterRule>elements was silently dropping the entire notification config. The config is now parsed correctly, persisted with prefix/suffix filters, serialized back inGetBucketNotificationConfigurationresponses, and applied during event delivery.Checklist
./mvnw testpasses locally