Remove HedLogger - addresses issue #1189 #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated HedLogger utility class from the codebase, addressing issue #1189. The removal is clean with all references properly updated.
Changes:
- Removed HedLogger class and its associated test file
- Cleaned up logger parameter from file_dictionary.py methods
- Fixed minor formatting and spelling issues in test data and documentation
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hed/tools/util/hed_logger.py | Removed entire HedLogger class implementation |
| tests/tools/util/test_hed_logger.py | Removed all unit tests for HedLogger |
| hed/tools/init.py | Removed HedLogger import from public API |
| hed/tools/analysis/file_dictionary.py | Removed logger parameter and related documentation from output_files method |
| spec_tests/hed-tests/json_test_data/validation_tests/TAG_INVALID.json | Fixed spelling: "white space" to "whitespace" |
| spec_tests/hed-tests/json_test_data/validation_tests/SCHEMA_LOAD_FAILED.json | Removed trailing whitespace from test name |
| RELEASE_GUIDE.md | Fixed markdown formatting and updated Zenodo URL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.