-
Notifications
You must be signed in to change notification settings - Fork 5
Support contao twig slot layouts #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8cfc3bd
add entrypoint factory
koertho 35e304d
add default name constant
koertho 5fb8364
extend entrypoints
koertho b054c17
current working state
koertho d03ae47
work on entrypoint creation
koertho c3469b2
enhance code, cleanup
koertho b9b845f
remove dead code
koertho 227d3b2
use builder for legacy layouts, deprecated old implementations, updat…
koertho 05d2b09
update workflow
koertho 3ea1145
another workflow update
koertho c9d37f0
small fixes
koertho 9e0691c
run rector and phpstan
koertho 300c359
phpstan
koertho 838c308
ecs
koertho dd9db02
fix tests, more deprecations
koertho 86b5808
add entrypoint tests, update docs, fix review comments
koertho 7f9eaee
updated changelog
koertho 3829297
update workflow, some adjustments
koertho 9ca8571
another workflow update
koertho 556b2fe
do not run tests with 5.7
koertho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,4 +8,5 @@ composer.json~ | |
| composer.phar | ||
| .ddev/ | ||
| .phpunit.result.cache | ||
| phpunit.xml.dist.bak | ||
| phpunit.xml.dist.bak | ||
| .codex | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * Copyright (c) 2022 Heimrich & Hannot GmbH | ||
| * | ||
| * @license LGPL-3.0-or-later | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| use HeimrichHannot\EncoreBundle\Asset\FrontendAsset; | ||
| use HeimrichHannot\EncoreBundle\Asset\TemplateAsset; | ||
| use HeimrichHannot\EncoreBundle\EntryPoint\EntryPointBuilderFactory; | ||
| use Psr\Cache\CacheItemPoolInterface; | ||
| use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator; | ||
| use Symfony\WebpackEncoreBundle\Asset\TagRenderer; | ||
|
|
||
| use function Symfony\Component\DependencyInjection\Loader\Configurator\service; | ||
|
|
||
| return static function (ContainerConfigurator $container): void { | ||
| $services = $container->services(); | ||
|
|
||
| $services | ||
| ->defaults() | ||
| ->autowire() | ||
| ->bind('$bundleConfig', '%huh_encore%') | ||
| ->bind('$webDir', '%contao.web_dir%') | ||
| ->bind('$encoreCache', service('webpack_encore.cache')) | ||
| ->bind(CacheItemPoolInterface::class, service('webpack_encore.cache')) | ||
| ->bind(TagRenderer::class, service('webpack_encore.tag_renderer')) | ||
| ; | ||
|
|
||
| $services | ||
| ->load('HeimrichHannot\\EncoreBundle\\', '../src/{Asset,Collection,Command,DataContainer,EventListener,Helper}/*') | ||
| ->exclude('../src/Asset/{EntrypointCollection.php}') | ||
| ->public() | ||
| ->autoconfigure() | ||
| ; | ||
|
|
||
| $services | ||
| ->set(EntryPointBuilderFactory::class) | ||
| ; | ||
|
|
||
| $services | ||
| ->alias('huh.encore.asset.frontend', FrontendAsset::class) | ||
| ->public() | ||
| ; | ||
|
|
||
| $services | ||
| ->alias('huh.encore.asset.template', TemplateAsset::class) | ||
| ->public() | ||
| ; | ||
| }; |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,19 @@ | ||
| parameters: | ||
| ignoreErrors: | ||
| - | ||
| message: "#^Offset 'fields' on array\\{\\} in isset\\(\\) does not exist\\.$#" | ||
| message: '#^Call to method getLayout\(\) on an unknown class Contao\\CoreBundle\\Event\\LayoutEvent\.$#' | ||
| identifier: class.notFound | ||
| count: 2 | ||
| path: tests/EventListener/DcaField/EncoreEntriesSelectFieldListenerTest.php | ||
| path: src/EventListener/InjectPageEntriesListener.php | ||
|
|
||
| - | ||
| message: '#^Call to method getPage\(\) on an unknown class Contao\\CoreBundle\\Event\\LayoutEvent\.$#' | ||
| identifier: class.notFound | ||
| count: 2 | ||
| path: src/EventListener/InjectPageEntriesListener.php | ||
|
|
||
| - | ||
| message: '#^Parameter \$event of method HeimrichHannot\\EncoreBundle\\EventListener\\InjectPageEntriesListener\:\:onLayoutEvent\(\) has invalid type Contao\\CoreBundle\\Event\\LayoutEvent\.$#' | ||
| identifier: class.notFound | ||
| count: 1 | ||
| path: src/EventListener/InjectPageEntriesListener.php | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,7 @@ | ||
| parameters: | ||
| level: 4 | ||
| level: 5 | ||
| paths: | ||
| - src | ||
| - tests | ||
| - contao | ||
| universalObjectCratesClasses: | ||
| - Contao\LayoutModel | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.